From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yuri Khan <yurivkhan@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad
Date: Fri, 6 Jul 2012 10:03:50 -0700 [thread overview]
Message-ID: <20120706170350.GA9909@core.coreip.homeip.net> (raw)
In-Reply-To: <CAP_d_8WLyGPtfWY3Po4yYyg2L7EiWuWuF6X4WZ+Me6LMLwfDCQ@mail.gmail.com>
On Fri, Jul 06, 2012 at 11:57:44PM +0700, Yuri Khan wrote:
> On Fri, Jul 6, 2012 at 11:32 PM, Yuri Khan <yurivkhan@gmail.com> wrote:
>
> > When I add a usbhid option quirks=0x0738:0x4540:0x4 (so that usbhid does
> > not attempt to handle this device) and rebuild the xpad module with the
> > following patch, the device works as expected. Dmitry Torokhov, the
> > current maintainer of input drivers, suggested that I include a change
> > to add the usbhid quirk in my patch.
>
> Of course the good idea only ever comes after the fact. If I change
> usbhid to ignore this vendor:device unconditionally, then xpad should
> also always handle it regardless of interface class/subclass/protocol,
> right?
Yes.
--
Dmitry
next prev parent reply other threads:[~2012-07-06 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 16:32 [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad Yuri Khan
2012-07-06 16:32 ` [PATCH 1/1] " Yuri Khan
2012-07-06 16:57 ` [PATCH 0/1] " Yuri Khan
2012-07-06 17:03 ` Dmitry Torokhov [this message]
2012-07-08 5:49 ` [PATCH v2 1/1] Input: xpad - Handle all variations " Yuri Khan
2012-07-09 14:08 ` Jiri Kosina
2012-07-09 15:52 ` Yuri Khan
2012-07-10 17:33 ` [PATCH v3 " Yuri Khan
2012-07-10 20:05 ` Jiri Kosina
2012-07-10 20:42 ` Dmitry Torokhov
2012-07-11 7:02 ` [PATCH v4 " Yuri Khan
2012-07-11 7:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706170350.GA9909@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yurivkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).