From: "Theodore Ts'o" <tytso@mit.edu>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, rtc-linux@googlegroups.com
Subject: Re: rtc: wm831x: Feed the write counter into device_add_randomness()
Date: Fri, 6 Jul 2012 17:23:04 -0400 [thread overview]
Message-ID: <20120706212304.GA4841@thunk.org> (raw)
In-Reply-To: <1341519557-5115-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, Jul 05, 2012 at 08:19:17PM -0000, Mark Brown wrote:
> The tamper evident features of the RTC include the "write counter" which
> is a pseudo-random number regenerated whenever we set the RTC. Since this
> value is unpredictable it should provide some useful seeding to the random
> number generator.
>
> Only do this on boot since the goal is to seed the pool rather than add
> useful entropy.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> add_device_randomness() has only just been added in -next, this will
> need to either wait until after the merge window or be merged along with
> the patch adding it.
Thanks, I've added this to the /dev/random git tree.
- Ted
prev parent reply other threads:[~2012-07-06 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 20:19 [PATCH] rtc: wm831x: Feed the write counter into device_add_randomness() Mark Brown
2012-07-06 21:23 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706212304.GA4841@thunk.org \
--to=tytso@mit.edu \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox