From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756606Ab2GFVXO (ORCPT ); Fri, 6 Jul 2012 17:23:14 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:37377 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220Ab2GFVXM (ORCPT ); Fri, 6 Jul 2012 17:23:12 -0400 Date: Fri, 6 Jul 2012 17:23:04 -0400 From: "Theodore Ts'o" To: Mark Brown Cc: Alessandro Zummo , Andrew Morton , linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, rtc-linux@googlegroups.com Subject: Re: rtc: wm831x: Feed the write counter into device_add_randomness() Message-ID: <20120706212304.GA4841@thunk.org> Mail-Followup-To: Theodore Ts'o , Mark Brown , Alessandro Zummo , Andrew Morton , linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, rtc-linux@googlegroups.com References: <1341519557-5115-1-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341519557-5115-1-git-send-email-broonie@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 05, 2012 at 08:19:17PM -0000, Mark Brown wrote: > The tamper evident features of the RTC include the "write counter" which > is a pseudo-random number regenerated whenever we set the RTC. Since this > value is unpredictable it should provide some useful seeding to the random > number generator. > > Only do this on boot since the goal is to seed the pool rather than add > useful entropy. > > Signed-off-by: Mark Brown > add_device_randomness() has only just been added in -next, this will > need to either wait until after the merge window or be merged along with > the patch adding it. Thanks, I've added this to the /dev/random git tree. - Ted