From: Greg KH <gregkh@linuxfoundation.org>
To: Sebastian Benvenuti <sebastianbenvenuti@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: usbduxsigma: Syntax issue fixes
Date: Fri, 6 Jul 2012 15:55:32 -0700 [thread overview]
Message-ID: <20120706225532.GE10471@kroah.com> (raw)
In-Reply-To: <1340859660-28813-1-git-send-email-sebastianbenvenuti@gmail.com>
On Thu, Jun 28, 2012 at 02:01:00AM -0300, Sebastian Benvenuti wrote:
> fixed "many quoted string split across lines" issues,
> replaced "printk(KERN_ERR" for "pr_err("
> and replaced "printk(KERN_INFO" for "pr_info("
>
> Signed-off-by: Sebastian Benvenuti <sebastianbenvenuti@gmail.com>
Where was...
Ok, you get the idea now.
Please fix up your patch numbering and resend these properly, in a
format that makes sense (hint, your current numbering made no sense...)
Also, stop doing:
> this_usbduxsub->dux_commands, SIZEOFDUXBUFFER,
> &nsent, BULK_TIMEOUT);
> if (result < 0)
> - dev_err(&this_usbduxsub->interface->dev, "comedi%d: "
> - "could not transmit dux_command to the usb-device, "
> + dev_err(&this_usbduxsub->interface->dev, "comedi%d: " \
> + "could not transmit dux_command to the usb-device, " \
> "err=%d\n", this_usbduxsub->comedidev->minor, result);
The '\' stuff is pointless and wrong.
greg k-h
prev parent reply other threads:[~2012-07-06 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 5:01 [PATCH 5/5] Staging: comedi: usbduxsigma: Syntax issue fixes Sebastian Benvenuti
2012-07-06 22:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706225532.GE10471@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastianbenvenuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox