public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	j-keerthy@ti.com, grant.likely@secretlab.ca, b-cousson@ti.com,
	kbaidarov@dev.rtsoft.ru
Subject: Re: [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor
Date: Fri, 6 Jul 2012 16:27:37 -0700	[thread overview]
Message-ID: <20120706232737.GA18598@kroah.com> (raw)
In-Reply-To: <1341355030-20800-2-git-send-email-eduardo.valentin@ti.com>

On Wed, Jul 04, 2012 at 01:37:07AM +0300, Eduardo Valentin wrote:
> In the System Control Module, OMAP supplies a voltage reference
> and a temperature sensor feature that are gathered in the band
> gap voltage and temperature sensor (VBGAPTS) module. The band
> gap provides current and voltage reference for its internal
> circuits and other analog IP blocks. The analog-to-digital
> converter (ADC) produces an output value that is proportional
> to the silicon temperature.
> 
> This patch provides a platform driver which expose this feature.
> It is moduled as a MFD child of the System Control Module core
> MFD driver.
> 
> This driver provides only APIs to access the device properties,
> like temperature, thresholds and update rate.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/staging/Kconfig                       |    2 +
>  drivers/staging/Makefile                      |    1 +

By not including the files these files "include" you just broke the
build at this point in the patch series, which isn't good.

Care to redo this series, so that it can build at each step of the way
(you might do this by just adding the Kconfig and Makefile entries as
the last patch), and then I will be glad to apply it to the tree.

Oh, and yes, this implies that I have no problem taking this driver for
the staging tree :)

thanks,

greg k-h

  reply	other threads:[~2012-07-06 23:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 22:37 [PATCH 0/4] staging: adding OMAP bandgap driver Eduardo Valentin
2012-07-03 22:37 ` [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor Eduardo Valentin
2012-07-06 23:27   ` Greg Kroah-Hartman [this message]
2012-07-07  6:48     ` Valentin, Eduardo
2012-07-03 22:37 ` [PATCH 2/4] staging: omap-thermal: common code to expose driver to thermal framework Eduardo Valentin
2012-07-03 22:37 ` [PATCH 3/4] staging: omap-thermal: add OMAP4 data structures Eduardo Valentin
2012-07-03 22:37 ` [PATCH 4/4] staging: omap-thermal: add OMAP5 " Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706232737.GA18598@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=b-cousson@ti.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=eduardo.valentin@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=j-keerthy@ti.com \
    --cc=kbaidarov@dev.rtsoft.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox