From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Alessandro Rubini <rubini@cvml.unipv.it>,
Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] Input: synaptics - add sysfs access to firmware ID & board ID
Date: Sat, 7 Jul 2012 18:16:21 -0700 [thread overview]
Message-ID: <20120708011621.GG19007@core.coreip.homeip.net> (raw)
In-Reply-To: <20120704130848.GA316@polaris.bitmath.org>
On Wed, Jul 04, 2012 at 03:08:48PM +0200, Henrik Rydberg wrote:
> On Wed, Jul 04, 2012 at 05:07:17PM +0800, Daniel Kurtz wrote:
> > Allow userspace to query firmware ID and board ID, which are read and
> > cached during device initialization.
> >
> > This information can be read, for instance, by a userspace feedback
> > reporting tool, to include this information in its reports.
> >
> > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> > ---
> > drivers/input/mouse/synaptics.c | 41 +++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 41 insertions(+), 0 deletions(-)
>
> Still reluctant here, but I am fine with whatever Dmitry thinks about it.
I do not think we need to have additional attributes - reporting
tools will collect kernel logs so since your previous change dumps the
data there that is all we need.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-07-08 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 9:07 [PATCH 1/2 v2] Input: synaptics - print firmware ID and board number at init Daniel Kurtz
2012-07-04 9:07 ` [PATCH 2/2 v2] Input: synaptics - add sysfs access to firmware ID & board ID Daniel Kurtz
2012-07-04 13:08 ` Henrik Rydberg
2012-07-08 1:16 ` Dmitry Torokhov [this message]
2012-07-04 12:56 ` [PATCH 1/2 v2] Input: synaptics - print firmware ID and board number at init Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120708011621.GG19007@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rubini@cvml.unipv.it \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox