From: Tejun Heo <tj@kernel.org>
To: Aristeu Rozanski <aris@redhat.com>
Cc: linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
Hugh Dickins <hughd@google.com>, Hillf Danton <dhillf@gmail.com>
Subject: Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory
Date: Mon, 9 Jul 2012 10:28:31 -0700 [thread overview]
Message-ID: <20120709172831.GF1341@google.com> (raw)
In-Reply-To: <20120709172220.GE1341@google.com>
On Mon, Jul 09, 2012 at 10:22:20AM -0700, Tejun Heo wrote:
> > Changing subsys_bits via remount is being deprecated. No need to
> > worry about this.
>
> Also, why does this matter? The xattrs are kept in cgrp anyway. Why
> does keeping dentry/inode around make difference?
Ah, okay, the file xattrs are kept in cfe which goes away on file
deletion. :)
While changing subsys via remount is going away, I think removing
files selectively is still nice to have (even for single hierarchy).
I wish it were implemented differently tho. As cgroup_rm_file()
already has @cft argument, wouldn't it be better to e.g. add @subsys
arg to cgroup_clear_directory() and let that walk subsys->cftsets
instead?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-07-09 17:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 14:29 [PATCH v3 0/3] cgroup: add xattr support Aristeu Rozanski
2012-07-02 14:29 ` [PATCH v3 1/3] xattr: extract simple_xattr code from tmpfs Aristeu Rozanski
2012-07-03 16:53 ` [PATCH v4 " Aristeu Rozanski
2012-07-02 14:29 ` [PATCH v3 2/3] cgroup: revise how we re-populate root directory Aristeu Rozanski
2012-07-09 17:17 ` Tejun Heo
2012-07-09 17:22 ` Tejun Heo
2012-07-09 17:28 ` Tejun Heo [this message]
2012-07-10 19:27 ` Aristeu Rozanski
2012-07-17 13:56 ` Aristeu Rozanski
2012-07-17 18:38 ` Tejun Heo
2012-07-17 21:29 ` Aristeu Rozanski
2012-07-17 21:40 ` Tejun Heo
2012-07-18 14:16 ` Aristeu Rozanski
2012-07-18 16:32 ` Tejun Heo
2012-07-02 14:29 ` [PATCH v3 3/3] cgroup: add xattr support Aristeu Rozanski
2012-07-17 20:41 ` [PATCH v3 0/3] " Tejun Heo
2012-07-18 20:02 ` Hugh Dickins
2012-07-18 22:10 ` Tejun Heo
2012-07-19 1:11 ` Hugh Dickins
2012-07-20 17:59 ` Aristeu Rozanski
2012-07-20 18:04 ` Tejun Heo
2012-08-07 15:22 ` Aristeu Rozanski
2012-07-22 19:12 ` Hugh Dickins
2012-07-23 18:12 ` Aristeu Rozanski
2012-07-24 18:28 ` Tejun Heo
2012-07-24 21:44 ` Aristeu Rozanski
2012-07-20 18:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709172831.GF1341@google.com \
--to=tj@kernel.org \
--cc=aris@redhat.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).