* [PATCH] regulator: da9052: Use for_each_child_of_node() macro @ 2012-07-07 1:46 Axel Lin 2012-07-09 3:23 ` [PATCH RFT 2/2] regulator: twl: Convert twl6030ldo_ops to [get|set]_voltage_sel Axel Lin 2012-07-09 18:39 ` [PATCH] regulator: da9052: Use for_each_child_of_node() macro Mark Brown 0 siblings, 2 replies; 3+ messages in thread From: Axel Lin @ 2012-07-07 1:46 UTC (permalink / raw) To: Mark Brown Cc: David Dajun Chen, Ashish Jangam, Ying-Chun Liu (PaulLiu), Liam Girdwood, linux-kernel Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/da9052-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index 88976d8..5f8f71a 100644 --- a/drivers/regulator/da9052-regulator.c +++ b/drivers/regulator/da9052-regulator.c @@ -405,8 +405,7 @@ static int __devinit da9052_regulator_probe(struct platform_device *pdev) if (!nproot) return -ENODEV; - for (np = of_get_next_child(nproot, NULL); np; - np = of_get_next_child(nproot, np)) { + for_each_child_of_node(nproot, np) { if (!of_node_cmp(np->name, regulator->info->reg_desc.name)) { config.init_data = of_get_regulator_init_data( -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH RFT 2/2] regulator: twl: Convert twl6030ldo_ops to [get|set]_voltage_sel 2012-07-07 1:46 [PATCH] regulator: da9052: Use for_each_child_of_node() macro Axel Lin @ 2012-07-09 3:23 ` Axel Lin 2012-07-09 18:39 ` [PATCH] regulator: da9052: Use for_each_child_of_node() macro Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Axel Lin @ 2012-07-09 3:23 UTC (permalink / raw) To: Mark Brown Cc: David Dajun Chen, Ashish Jangam, Ying-Chun Liu (PaulLiu), Liam Girdwood, linux-kernel Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/twl-regulator.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c index bb51dec..de99b78 100644 --- a/drivers/regulator/twl-regulator.c +++ b/drivers/regulator/twl-regulator.c @@ -560,37 +560,27 @@ static struct regulator_ops twl6030coresmps_ops = { }; static int -twl6030ldo_set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV, - unsigned *selector) +twl6030ldo_set_voltage_sel(struct regulator_dev *rdev, unsigned selector) { struct twlreg_info *info = rdev_get_drvdata(rdev); - int vsel; - if ((min_uV/1000 < info->min_mV) || (max_uV/1000 > info->max_mV)) - return -EDOM; - - vsel = DIV_ROUND_UP(min_uV - rdev->desc->min_uV, rdev->desc->uV_step); - *selector = vsel; - - return twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE, vsel); + return twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE, + selector); } -static int twl6030ldo_get_voltage(struct regulator_dev *rdev) +static int twl6030ldo_get_voltage_sel(struct regulator_dev *rdev) { struct twlreg_info *info = rdev_get_drvdata(rdev); int vsel = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE); - if (vsel < 0) - return vsel; - - return rdev->desc->min_uV + vsel * rdev->desc->uV_step; + return vsel; } static struct regulator_ops twl6030ldo_ops = { .list_voltage = regulator_list_voltage_linear, - .set_voltage = twl6030ldo_set_voltage, - .get_voltage = twl6030ldo_get_voltage, + .set_voltage_sel = twl6030ldo_set_voltage_sel, + .get_voltage_sel = twl6030ldo_get_voltage_sel, .enable = twl6030reg_enable, .disable = twl6030reg_disable, -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: da9052: Use for_each_child_of_node() macro 2012-07-07 1:46 [PATCH] regulator: da9052: Use for_each_child_of_node() macro Axel Lin 2012-07-09 3:23 ` [PATCH RFT 2/2] regulator: twl: Convert twl6030ldo_ops to [get|set]_voltage_sel Axel Lin @ 2012-07-09 18:39 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Mark Brown @ 2012-07-09 18:39 UTC (permalink / raw) To: Axel Lin Cc: David Dajun Chen, Ashish Jangam, Ying-Chun Liu (PaulLiu), Liam Girdwood, linux-kernel [-- Attachment #1: Type: text/plain, Size: 123 bytes --] On Sat, Jul 07, 2012 at 09:46:45AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@gmail.com> Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-09 18:39 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-07 1:46 [PATCH] regulator: da9052: Use for_each_child_of_node() macro Axel Lin 2012-07-09 3:23 ` [PATCH RFT 2/2] regulator: twl: Convert twl6030ldo_ops to [get|set]_voltage_sel Axel Lin 2012-07-09 18:39 ` [PATCH] regulator: da9052: Use for_each_child_of_node() macro Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).