public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Marek Belisko <marek.belisko@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line
Date: Mon, 9 Jul 2012 12:25:41 -0700	[thread overview]
Message-ID: <20120709192541.GA5671@kroah.com> (raw)
In-Reply-To: <1341662719-25752-2-git-send-email-devendra.aaru@gmail.com>

On Sat, Jul 07, 2012 at 05:35:13PM +0530, Devendra Naga wrote:
> The following warns fixed
> 
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: ERROR: code indent should use tabs where possible
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: WARNING: please, no spaces at the start of a line
> 
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> index 0bd080c..c709671 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> @@ -2029,7 +2029,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
>  	ft1000_write_reg(dev, FT1000_REG_SUP_ISR, tempword);
>  
>          // Read interrupt type
> -        inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);
> +		inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);

Did you just indent this one too many tabs?  Remember, a tab is 8
spaces, this should have lined up wit the line above it.  Which, for
some odd reason, is also using spaces, so why didn't that get fixed
also?

thanks,

greg k-h

  reply	other threads:[~2012-07-09 19:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-07 12:05 [PATCH 1/8] staging/ft1000: fix the no brace needed warning in ft1000_interrupt Devendra Naga
2012-07-07 12:05 ` [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line Devendra Naga
2012-07-09 19:25   ` Greg KH [this message]
2012-07-07 12:05 ` [PATCH 3/8] staging/ft1000: fix sparse warning Devendra Naga
2012-07-07 12:05 ` [PATCH 4/8] staging/ft1000: fix sparse warning about the kernel thread handler function Devendra Naga
2012-07-07 12:05 ` [PATCH 5/8] staging/ft1000: fix the no brace needed warning in ft1000_read_fifo_len Devendra Naga
2012-07-07 12:05 ` [PATCH 6/8] staging/ft1000: fix the foo * bar warning Devendra Naga
2012-07-07 12:05 ` [PATCH 7/8] staging/ft1000-pcmcia: fix checkpatch warnings Devendra Naga
2012-07-07 12:05 ` [PATCH 8/8] staging/ft1000: remove unnecessary assignment of ret with STATUS_SUCCESS Devendra Naga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709192541.GA5671@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=devendra.aaru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox