* [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
@ 2012-07-08 9:25 Toshiaki Yamane
2012-07-08 15:12 ` devendra.aaru
2012-07-09 19:33 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Toshiaki Yamane @ 2012-07-08 9:25 UTC (permalink / raw)
To: greg; +Cc: sjakub, linux-kernel, Toshiaki Yamane
This change is inspired by checkpatch.
Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 510d796..f63c1d3 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -782,20 +782,20 @@ static int __init asus_oled_init(void)
oled_class = class_create(THIS_MODULE, ASUS_OLED_UNDERSCORE_NAME);
if (IS_ERR(oled_class)) {
- printk(KERN_ERR "Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
+ pr_err("Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
return PTR_ERR(oled_class);
}
retval = class_create_file(oled_class, &class_attr_version.attr);
if (retval) {
- printk(KERN_ERR "Error creating class version file\n");
+ pr_err("Error creating class version file\n");
goto error;
}
retval = usb_register(&oled_driver);
if (retval) {
- printk(KERN_ERR "usb_register failed. Error number %d\n", retval);
+ pr_err("usb_register failed. Error number %d\n", retval);
goto error;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
2012-07-08 9:25 [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...) Toshiaki Yamane
@ 2012-07-08 15:12 ` devendra.aaru
2012-07-09 19:33 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: devendra.aaru @ 2012-07-08 15:12 UTC (permalink / raw)
To: Toshiaki Yamane; +Cc: greg, sjakub, linux-kernel
git format-patch -s --subject-prfix="PATCH V2' will be better,
On Sun, Jul 8, 2012 at 2:55 PM, Toshiaki Yamane <yamanetoshi@gmail.com> wrote:
> This change is inspired by checkpatch.
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
> ---
> drivers/staging/asus_oled/asus_oled.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 510d796..f63c1d3 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -782,20 +782,20 @@ static int __init asus_oled_init(void)
> oled_class = class_create(THIS_MODULE, ASUS_OLED_UNDERSCORE_NAME);
>
> if (IS_ERR(oled_class)) {
> - printk(KERN_ERR "Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
> + pr_err("Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
> return PTR_ERR(oled_class);
> }
>
> retval = class_create_file(oled_class, &class_attr_version.attr);
> if (retval) {
> - printk(KERN_ERR "Error creating class version file\n");
> + pr_err("Error creating class version file\n");
> goto error;
> }
>
> retval = usb_register(&oled_driver);
>
> if (retval) {
> - printk(KERN_ERR "usb_register failed. Error number %d\n", retval);
> + pr_err("usb_register failed. Error number %d\n", retval);
> goto error;
> }
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
2012-07-08 9:25 [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...) Toshiaki Yamane
2012-07-08 15:12 ` devendra.aaru
@ 2012-07-09 19:33 ` Greg KH
2012-07-09 23:35 ` yamanetoshi
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2012-07-09 19:33 UTC (permalink / raw)
To: Toshiaki Yamane; +Cc: sjakub, linux-kernel
On Sun, Jul 08, 2012 at 06:25:47PM +0900, Toshiaki Yamane wrote:
> This change is inspired by checkpatch.
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
> ---
> drivers/staging/asus_oled/asus_oled.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Sorry, someone beat you to this very change by a few hours :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
2012-07-09 19:33 ` Greg KH
@ 2012-07-09 23:35 ` yamanetoshi
0 siblings, 0 replies; 4+ messages in thread
From: yamanetoshi @ 2012-07-09 23:35 UTC (permalink / raw)
To: Greg KH; +Cc: sjakub, linux-kernel
No problem :-)
On Tue, Jul 10, 2012 at 4:33 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Jul 08, 2012 at 06:25:47PM +0900, Toshiaki Yamane wrote:
>> This change is inspired by checkpatch.
>>
>> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
>> ---
>> drivers/staging/asus_oled/asus_oled.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Sorry, someone beat you to this very change by a few hours :(
>
> greg k-h
--
Regards,
.
.
...
Yamane Toshiaki
yamanetoshi@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-09 23:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-08 9:25 [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...) Toshiaki Yamane
2012-07-08 15:12 ` devendra.aaru
2012-07-09 19:33 ` Greg KH
2012-07-09 23:35 ` yamanetoshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox