public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hitoshi Nakamori <hitoshi.nakamori@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH 1/4] staging:rts_pstor: Fix coding style issue in ms.c
Date: Mon, 9 Jul 2012 12:42:11 -0700	[thread overview]
Message-ID: <20120709194211.GA17980@kroah.com> (raw)
In-Reply-To: <1341710152-4266-1-git-send-email-hitoshi.nakamori@gmail.com>

On Sun, Jul 08, 2012 at 10:15:48AM +0900, Hitoshi Nakamori wrote:
> This is a patch to the ms.c that fixes up some brace warning found by checkpatch.pl tool.

Please wrap your comments at 72 columns.

As much as I endorce splitting patches up into tiny pieces, this is a
bit overkill, as you now have 4 patches with the same identical subject:

That implies that all of these could just be one patch, right?  Please
do that.

thanks,

greg k-h

  parent reply	other threads:[~2012-07-09 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-08  1:15 [PATCH 1/4] staging:rts_pstor: Fix coding style issue in ms.c Hitoshi Nakamori
2012-07-08  1:15 ` [PATCH 2/4] Staging:rts_pstor: Fix brace " Hitoshi Nakamori
2012-07-08  1:15 ` [PATCH 3/4] " Hitoshi Nakamori
2012-07-08  1:15 ` [PATCH 4/4] Staging: rts_pstor: " Hitoshi Nakamori
2012-07-09 19:42 ` Greg KH [this message]
2012-07-09 21:05   ` [PATCH 1/4] staging:rts_pstor: Fix " Hitoshi NAKAMORI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709194211.GA17980@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hitoshi.nakamori@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox