Re: [PATCH 0/3] staging: bcm: Cleanup bcm driver

Dan Carpenter
2012-07-10T13:31:18Z

On Tue, Jul 10, 2012 at 09:24:23AM -0400, Kevin McKinney wrote:
> On Tue, Jul 10, 2012 at 8:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Jul 10, 2012 at 08:38:41AM -0400, Kevin McKinney wrote:
> >> On Mon, Jul 09, 2012 at 11:48:09PM -0300, Marcos Souza wrote:
> >> > 2012/7/9 Kevin McKinney <klmckinney1@gmail.com>:
> >> > > On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote:
> >> > >> Hi Kernel guys!
> >> > >>
> >> > >> This new patchset tries to clean a little the bcm driver, removing
> >> > >> some unused macros and some dead code.
> >> > >>
> >> > >> These macros and dead code were reported by the forgotten-macros tool
> >> > >> (https://github.com/marcosps/forgotten_macros).
> >> > >>
> >> > >> The tool is under development, but all the patches looks like OK.
> >> > >>
> >> > >> This patchset is based in staging-next.
> >> > >>
> >> > >> Thanks guys!
> >> > >
> >> > > The patchset looks good!
> >> >
> >> > Thanks for the answer Kevin!!
> >> >
> >> > So, do I have your ack?
> >> Yes, I ack.
> >
> > The normal format is:
> >
> > Acked-by: Your Name <email@address.com>
> >
> > Some maintainers have scripts which pick Acked-by tags automatically
> > or even if they don't they can copy and paste it.
>
> Okay, thanks for this info Dan. I will see if I can write this script.
>

No, what I'm saying is that I know Dave Miller uses a script which
pulls the Acked-by's out of email threads and adds them
automatically. I don't know how Greg does it, but it's better to
use the normal format.

regards,
dan carpenter