From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957Ab2GJPsf (ORCPT ); Tue, 10 Jul 2012 11:48:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48645 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930Ab2GJPse (ORCPT ); Tue, 10 Jul 2012 11:48:34 -0400 Date: Tue, 10 Jul 2012 16:48:30 +0100 From: Mel Gorman To: JoonSoo Kim Cc: David Rientjes , akpm@linux-foundation.org, Pekka Enberg , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0 Message-ID: <20120710154829.GA9222@suse.de> References: <1341588521-17744-1-git-send-email-js1304@gmail.com> <20120710104722.GB14154@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2012 at 12:24:41AM +0900, JoonSoo Kim wrote: > > That would be functionally similar to your patch but it will preserve git > > blame, churn less code and be harder to make mistakes with in the unlikely > > event a third call to alloc_pages_direct_compact is ever added. > > Your suggestion looks good. > But, the size of page_alloc.o is more than before. > > I test 3 approaches, vanilla, always_inline and > wrapping(alloc_page_direct_compact which is your suggestion). > In my environment (v3.5-rc5, gcc 4.6.3, x86_64), page_alloc.o shows > below number. > > total, .text section, .text.unlikely > page_alloc_vanilla.o: 93432, 0x510a, 0x243 > page_alloc_inline.o: 93336, 0x52ca, 0xa4 > page_alloc_wrapping.o: 93528, 0x515a, 0x238 > > Andrew said that inlining add only 26 bytes to .text of page_alloc.o, > but in my system, need more bytes. > Currently, I think this patch doesn't have obvious benefit, so I want > to drop it. > Any objections? > No objections to dropping the patch. It was at worth looking at so thanks for that. -- Mel Gorman SUSE Labs