From: Arnd Bergmann <arnd@arndb.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter
Date: Wed, 11 Jul 2012 10:45:02 +0000 [thread overview]
Message-ID: <201207111045.03275.arnd@arndb.de> (raw)
In-Reply-To: <1342000670-1005-1-git-send-email-tomoya.rohm@gmail.com>
On Wednesday 11 July 2012, Tomoya MORINAGA wrote:
> Currently, when a user wants to change UART clock,
> needs to modify this source code by hand.
> This patch enables changing UART clock by specifying UART clock
> as module parameter.
>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
This looks like a rather nonscalable solution if you get to systems
with lots of clocks.
Given that you are doing it for the uart clock, shouldn't that be
set from the uart driver using an ioctl like other serial ports do?
What would be the use case for an end user to override the module
parameter? Is it about platform specific settings or policy?
Arnd
next prev parent reply other threads:[~2012-07-11 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:57 [PATCH] misc/pch_phub: Enable UART clock setting by module parameter Tomoya MORINAGA
2012-07-11 10:45 ` Arnd Bergmann [this message]
2012-07-12 0:54 ` Tomoya MORINAGA
2012-07-24 23:57 ` Tomoya MORINAGA
2012-07-25 13:31 ` Arnd Bergmann
2012-07-31 10:36 ` Tomoya MORINAGA
2012-07-31 21:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207111045.03275.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox