From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujtisu.com>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
Rik van Riel <riel@redhat.com>, Ying Han <yinghan@google.com>,
Greg Thelen <gthelen@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 -mm] memcg: prevent from OOM with too many dirty pages
Date: Wed, 11 Jul 2012 19:21:06 -0700 [thread overview]
Message-ID: <20120711192106.b6b8232f.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1207111818380.1299@eggly.anvils>
On Wed, 11 Jul 2012 18:57:43 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> --- 3.5-rc6-mm1/mm/vmscan.c 2012-07-11 14:42:13.668335884 -0700
> +++ linux/mm/vmscan.c 2012-07-11 16:01:20.712814127 -0700
> @@ -726,7 +726,8 @@ static unsigned long shrink_page_list(st
> * writeback from reclaim and there is nothing else to
> * reclaim.
> */
> - if (!global_reclaim(sc) && PageReclaim(page))
> + if (!global_reclaim(sc) && PageReclaim(page) &&
> + may_enter_fs)
> wait_on_page_writeback(page);
> else {
> nr_writeback++;
um, that may_enter_fs test got removed because nobody knew why it was
there. Nobody knew why it was there because it was undocumented. Do
you see where I'm going with this?
next prev parent reply other threads:[~2012-07-12 2:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 14:50 [PATCH -mm] memcg: prevent from OOM with too many dirty pages Michal Hocko
2012-06-19 22:00 ` Andrew Morton
2012-06-20 8:27 ` Michal Hocko
2012-06-20 9:20 ` Mel Gorman
2012-06-20 9:55 ` Fengguang Wu
2012-06-20 9:59 ` Michal Hocko
2012-06-20 10:11 ` [PATCH v2 " Michal Hocko
2012-07-12 1:57 ` Hugh Dickins
2012-07-12 2:21 ` Andrew Morton [this message]
2012-07-12 3:13 ` Hugh Dickins
2012-07-12 7:05 ` Michal Hocko
2012-07-12 21:13 ` Andrew Morton
2012-07-12 22:42 ` Hugh Dickins
2012-07-13 8:21 ` Michal Hocko
2012-07-16 8:30 ` Hugh Dickins
2012-07-16 8:35 ` [PATCH mmotm] memcg: further prevent " Hugh Dickins
2012-07-16 9:26 ` Michal Hocko
2012-07-17 4:52 ` Hugh Dickins
2012-07-17 6:33 ` Michal Hocko
2012-07-16 21:08 ` Andrew Morton
2012-07-16 8:10 ` [PATCH v2 -mm] memcg: prevent from " Hugh Dickins
2012-07-16 8:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711192106.b6b8232f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujtisu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox