From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162774Ab2GLXRO (ORCPT ); Thu, 12 Jul 2012 19:17:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45402 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162577Ab2GLXRJ (ORCPT ); Thu, 12 Jul 2012 19:17:09 -0400 Date: Thu, 12 Jul 2012 16:17:07 -0700 From: Andrew Morton To: Andrew Morton Cc: Artem Bityutskiy , Al Viro , Linux FS Maling List , Linux Kernel Maling List Subject: Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt Message-Id: <20120712161707.d5bb6df2.akpm@linux-foundation.org> In-Reply-To: <20120712160951.74cbb3c1.akpm@linux-foundation.org> References: <1342103191-17406-1-git-send-email-dedekind1@gmail.com> <20120712160951.74cbb3c1.akpm@linux-foundation.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Jul 2012 16:09:51 -0700 Andrew Morton wrote: > > 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not > > enough to just cancel the job, we need to set the work_queued flag to zero > > as well. I could do this, but it is simpler to just remove this tiny > > optimization - we do not gain much with it. I caught this bug while doing > > some more testing. > > And lo, when I look at "what was changed", I see that this patchset > actually does *not* remove the cancel_delayed_work() call. What's up > with that? Ah, no. I was looking at the cancel_delayed_work() in hfs_put_super().