From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161468Ab2GLRan (ORCPT ); Thu, 12 Jul 2012 13:30:43 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52447 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932736Ab2GLRam (ORCPT ); Thu, 12 Jul 2012 13:30:42 -0400 Date: Thu, 12 Jul 2012 18:30:40 +0100 From: Mark Brown To: Dan Carpenter Cc: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet() Message-ID: <20120712173040.GT7256@opensource.wolfsonmicro.com> References: <20120711063602.GG11812@elgon.mountain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PPxI8paQBs33t8dK" Content-Disposition: inline In-Reply-To: <20120711063602.GG11812@elgon.mountain> X-Cookie: Advancement in position. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PPxI8paQBs33t8dK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote: > Smatch complains about this. I don't have a way to test this, but it > does look like we should unlock on error here. >=20 > Signed-off-by: Dan Carpenter Acke-dby: Mark Brown --PPxI8paQBs33t8dK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJP/wmfAAoJEBus8iNuMP3dLGEP/iXdWVHyQ7lhe6XvIdZPWqjc Hw53oO7ZZ2zQacLqQrg5wQypVnFEnSUbzXteUOjzDkJz5T6OmSM+fQX6wm2C7PFf QS+K8h9ntFBZ9dqATv6C+5usEhwB4kAqsAiK3+uOwhvVPX5trjaDj19CniDJXCpE 7VBLn8pcD+XZHjQhR3aK9nhlN6rtHbvlg1CDjLrPNm+J4Z/w60og7cs2mrvK9aKy DF3ux0+dBxpIpTNYozHLmdkhdLhXIsYk+BocNbvIxDOgs6yCdUwh7BjLC5Zv2vRl WPMbFILpQl4NaLJf91UBvQfbwbYHOPVEdDHUBRbnsqr/l3dioAqgOuQosYD7kXez bvJ6TMTS4iqex2XjbP98BPaYWoMolkrOULlpSMSB1cFpNuCMr9wbHBVBcGx2at/N LtjtEFRJweuPFAP2qRVSBQ7qW3jqNKAisd7cm8QM6Qcxr0oiVkKgcQD/YJjx0U34 Cc0+azMxv0329ZsGly/2YJV/Stt+FKgZCSjK1sCqhqNiBV3A+nj5AA/0bKokBix4 fukwXL0G9DXus9J7p+7RBBTBlXfmODbdPx/OGo45sJhx7V/Vdh95l+pSsg2Ek8VM gNnWgCF8QLGaWXiESZnhzqlZjQey+GwJ2jq90U1VrSKVmRPaxiiBlcbXqZLZgjsH yngPgeWroNJd9nUhYCRs =9xCq -----END PGP SIGNATURE----- --PPxI8paQBs33t8dK--