* [PATCH] wss_lib: fix suspend/resume
@ 2012-07-12 21:30 Ondrej Zary
2012-07-16 9:24 ` [alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Zary @ 2012-07-12 21:30 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, Kernel development list
By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
state fully on resume. But in fact, it can't as DMA is not restored so any
playback/capture running during suspend will fail to continue after resume.
Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- a/sound/isa/wss/wss_lib.c
+++ b/sound/isa/wss/wss_lib.c
@@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
{
.info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_MMAP_VALID |
- SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_SYNC_START),
.formats = (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
--
Ondrej Zary
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH] wss_lib: fix suspend/resume
2012-07-12 21:30 [PATCH] wss_lib: fix suspend/resume Ondrej Zary
@ 2012-07-16 9:24 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-07-16 9:24 UTC (permalink / raw)
To: Ondrej Zary; +Cc: Jaroslav Kysela, alsa-devel, Kernel development list
At Thu, 12 Jul 2012 23:30:31 +0200,
Ondrej Zary wrote:
>
> By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
> state fully on resume. But in fact, it can't as DMA is not restored so any
> playback/capture running during suspend will fail to continue after resume.
>
> Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Applied now. Thanks.
Takashi
>
> --- a/sound/isa/wss/wss_lib.c
> +++ b/sound/isa/wss/wss_lib.c
> @@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
> {
> .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_MMAP_VALID |
> - SNDRV_PCM_INFO_RESUME |
> SNDRV_PCM_INFO_SYNC_START),
> .formats = (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
> SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-16 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 21:30 [PATCH] wss_lib: fix suspend/resume Ondrej Zary
2012-07-16 9:24 ` [alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox