From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Pavel Emelyanov <xemul@openvz.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Doug Ledford <dledford@redhat.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH] ns: move free_nsproxy() out of do_exit() path
Date: Fri, 13 Jul 2012 14:08:06 -0700 [thread overview]
Message-ID: <20120713140806.b3d0fda8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342180088-22647-1-git-send-email-kirill.shutemov@linux.intel.com>
On Fri, 13 Jul 2012 14:48:08 +0300
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> free_nsproxy() is too heavy to be on exit path. Let's free namespaces
> asynchronously to not block exit_group() syscall.
Please be specific, and complete.
Why is it "too heavy"? Where is the time being spent? Is it spent in
D state or is it spent burning CPU cycles? Does the patch simply
offload the work into kernel threads, providing no net gain?
> The patch also fixes bug with free namespace without synchronize_rcu() through
> put_nsproxy().
I just don't understand this description. Please send a new one which
includes all details about the bug, including a description of
the user-visible effects of the bug.
next prev parent reply other threads:[~2012-07-13 21:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 11:48 [PATCH] ns: move free_nsproxy() out of do_exit() path Kirill A. Shutemov
2012-07-13 21:08 ` Andrew Morton [this message]
2012-07-13 22:23 ` Kirill A. Shutemov
2012-07-16 15:09 ` [PATCH v2] ns: do not block exit_task_namespaces() for a long time Kirill A. Shutemov
2012-07-16 15:39 ` Myklebust, Trond
2012-07-16 16:39 ` Kirill A. Shutemov
2012-07-16 16:53 ` Myklebust, Trond
2012-07-16 16:53 ` Al Viro
2012-07-16 17:16 ` Kirill A. Shutemov
2012-07-16 17:22 ` Al Viro
2012-07-16 21:05 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713140806.b3d0fda8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dledford@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=ldv@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox