public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Michael Chan <mchan@broadcom.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b
Date: Fri, 13 Jul 2012 15:09:08 +0100	[thread overview]
Message-ID: <20120713140907.GT13885@arachsys.com> (raw)
In-Reply-To: <1342186932.3265.8364.camel@edumazet-glaptop>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> Have you read firmware/README.AddingFirmware ?

I hadn't, but now I have, and if firmware upgrades are considered 'adding
new firmware', I agree this patch is wrong, and should have just removed the
obsolete bnx2-mips-09-6.2.1a file that is no longer used by the bnx2 driver.

However, not having dealt with cards that need these kinds of horrible
binary blobs before, I'm a little uncertain how I should be building
upstream kernels with CONFIG_FIRMWARE_IN_KERNEL and pulling in the correct
blobs from a linux-firmware checkout.

Is there a more automatic method than going through the source for each
configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the
relevant firmwares? Is there any way to give the kernel the location of
linux-firmware and have it compile in everything needed for the selected
drivers, as used to happen with the firmware/ subdirectory?
CONFIG_EXTRA_FIRMWARE_DIR doesn't seem to do anything with
CONFIG_EXTRA_FIRMWARE empty, so I don't think it does what I'm hoping?

Cheers,

Chris.

  reply	other threads:[~2012-07-13 14:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-13 13:04 [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b Chris Webb
2012-07-13 13:42 ` Eric Dumazet
2012-07-13 14:09   ` Chris Webb [this message]
2012-07-13 21:12     ` Michael Chan
2012-07-14  4:27     ` Ben Hutchings
2012-08-08  5:50 ` Jike Song
2012-08-08  5:58   ` David Miller
2012-08-08  6:17     ` Willy Tarreau
2012-08-08  6:27       ` Eric Dumazet
2012-08-08  6:49         ` Willy Tarreau
2012-08-08  7:00           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713140907.GT13885@arachsys.com \
    --to=chris@arachsys.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox