* [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning.
@ 2012-07-12 21:00 Marek Belisko
2012-07-13 14:45 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Marek Belisko @ 2012-07-12 21:00 UTC (permalink / raw)
To: lrg; +Cc: broonie, perex, tiwai, alsa-devel, linux-kernel, Marek Belisko
Fix following:
sound/soc/soc-dapm.c: In function ‘dapm_clock_event’:
sound/soc/soc-dapm.c:1021:1: warning: control reaches end of non-void function [-Wreturn-type]
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
sound/soc/soc-dapm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index f829d6f..eded657 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1018,6 +1018,7 @@ int dapm_clock_event(struct snd_soc_dapm_widget *w,
return 0;
}
#endif
+ return 0;
}
EXPORT_SYMBOL_GPL(dapm_clock_event);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning.
2012-07-12 21:00 [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning Marek Belisko
@ 2012-07-13 14:45 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-07-13 14:45 UTC (permalink / raw)
To: Marek Belisko; +Cc: lrg, perex, tiwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Thu, Jul 12, 2012 at 11:00:16PM +0200, Marek Belisko wrote:
> Fix following:
> sound/soc/soc-dapm.c: In function ‘dapm_clock_event’:
> sound/soc/soc-dapm.c:1021:1: warning: control reaches end of non-void function [-Wreturn-type]
Applied,:but:please:do:make:an:effort:to:use:subject:lines:appropriate:to
the:subsystem. As well as using a totally different style there's a
spelling issue, I very nearly deleted the patch unread because of these
things.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-13 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 21:00 [PATCH 1/2] sound:soc:soc-dmap: Fix compilation warning Marek Belisko
2012-07-13 14:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox