From: Oleg Nesterov <oleg@redhat.com>
To: Denys Vlasenko <vda.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Jonathan M. Foote" <jmfoote@cert.org>,
"H. J. Lu" <hjl.tools@gmail.com>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH v2] Extend core dump note section to contain file names of mapped files
Date: Fri, 13 Jul 2012 16:58:06 +0200 [thread overview]
Message-ID: <20120713145806.GA17217@redhat.com> (raw)
In-Reply-To: <201207122142.02137.vda.linux@googlemail.com>
On 07/12, Denys Vlasenko wrote:
>
> This note has the following format:
>
> long count -- how many files are mapped
> long page_size -- units for file_ofs
> array of [COUNT] elements of
> long start
> long end
> long file_ofs
> followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL...
All I can say, I believe the patch is correct.
Only one nit... Afaics, fill_files_note() has no callers without
CORE_DUMP_USE_REGSET, so perhaps you should either move it under
ifdef (to avoid the warning) or modify the !CORE_DUMP_USE_REGSET
code to use NT_FILE as well.
Otherwise I can't comment the patch, I simply do not know what
people do with the coredumps. But Denys certainly knows, he works
with the tools which need this info.
Oleg.
next prev parent reply other threads:[~2012-07-13 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 19:42 [PATCH v2] Extend core dump note section to contain file names of mapped files Denys Vlasenko
2012-07-13 14:58 ` Oleg Nesterov [this message]
2012-07-13 15:56 ` Andi Kleen
2012-07-13 17:20 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713145806.GA17217@redhat.com \
--to=oleg@redhat.com \
--cc=ak@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jan.kratochvil@redhat.com \
--cc=jmfoote@cert.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vda.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox