From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Khalid Aziz <khalid.aziz@hp.com>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
mikew@google.com, keescook@chromium.org,
gong.chen@linux.intel.com
Subject: Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs
Date: Fri, 13 Jul 2012 16:46:45 +0100 [thread overview]
Message-ID: <20120713154645.GA16059@srcf.ucam.org> (raw)
In-Reply-To: <20120713153827.GA8007@hp.com>
On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote:
> if (var->Attributes & 0x4)
> str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n");
I know you're just following the pattern of the existing code, but could
you change these to be more like
if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)
while you're at it? I think that'd be a worthwhile cleanup.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-07-13 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 15:38 [PATCH] Add missing attributes to EFI variable attribute print out from sysfs Khalid Aziz
2012-07-13 15:44 ` Kees Cook
2012-07-13 15:46 ` Matthew Garrett [this message]
2012-07-13 15:54 ` Khalid Aziz
2012-07-13 17:52 ` Khalid Aziz
2012-07-13 17:54 ` Matthew Garrett
2012-07-13 18:05 ` Khalid Aziz
[not found] ` <CAGTjWtA0LmQ-90zjYf0nho_LEra8nx32M1R7E6o=3S68UjfEHw@mail.gmail.com>
2012-07-13 19:10 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713154645.GA16059@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=gong.chen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=khalid.aziz@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox