From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Anton Arapov <anton@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] uprobes: kill insert_vm_struct()->uprobe_mmap()
Date: Fri, 13 Jul 2012 18:46:41 +0200 [thread overview]
Message-ID: <20120713164641.GA23575@redhat.com> (raw)
In-Reply-To: <20120713164552.GA23509@redhat.com>
Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma->vm_file != NULL.
And it is wrong. Again, get_user_pages() can not succeed before
vma_link(vma) makes is visible to find_vma(). And even if this
worked, we must not insert the new bp before this mapping is
visible to vma_prio_tree_foreach() for uprobe_unregister().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar.vnet.ibm.com>
---
mm/mmap.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index e5a4614..4fe2697 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2345,9 +2345,6 @@ int insert_vm_struct(struct mm_struct * mm, struct vm_area_struct * vma)
security_vm_enough_memory_mm(mm, vma_pages(vma)))
return -ENOMEM;
- if (vma->vm_file && uprobe_mmap(vma))
- return -EINVAL;
-
vma_link(mm, vma, prev, rb_link, rb_parent);
return 0;
}
--
1.5.5.1
prev parent reply other threads:[~2012-07-13 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 16:45 [PATCH 0/9] uprobes: misc, resend Oleg Nesterov
2012-07-13 16:46 ` [PATCH 1/9] uprobes: don't recheck vma/f_mapping in write_opcode() Oleg Nesterov
2012-07-13 16:46 ` [PATCH 2/9] uprobes: __replace_page() should not use page_address_in_vma() Oleg Nesterov
2012-07-13 16:46 ` [PATCH 3/9] uprobes: kill write_opcode()->lock_page(new_page) Oleg Nesterov
2012-07-13 16:46 ` [PATCH 4/9] uprobes: cleanup and document write_opcode()->lock_page(old_page) Oleg Nesterov
2012-07-13 16:46 ` [PATCH 5/9] uprobes: uprobe_mmap/munmap needs list_for_each_entry_safe() Oleg Nesterov
2012-07-13 16:46 ` [PATCH 6/9] uprobes: suppress uprobe_munmap() from mmput() Oleg Nesterov
2012-07-13 16:46 ` [PATCH 7/9] uprobes: fix overflow in vma_address/find_active_uprobe Oleg Nesterov
2012-07-13 16:46 ` [PATCH 8/9] uprobes: kill copy_vma()->uprobe_mmap() Oleg Nesterov
2012-07-13 16:46 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713164641.GA23575@redhat.com \
--to=oleg@redhat.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox