Re: [PATCH v2] Extend core dump note section to contain file names of mapped files

Oleg Nesterov
2012-07-13T15:00:47Z

On 07/12, Denys Vlasenko wrote:
>
> This note has the following format:
>
> long count -- how many files are mapped
> long page_size -- units for file_ofs
> array of [COUNT] elements of
> long start
> long end
> long file_ofs
> followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL...

All I can say, I believe the patch is correct.

Only one nit... Afaics, fill_files_note() has no callers without
CORE_DUMP_USE_REGSET, so perhaps you should either move it under
ifdef (to avoid the warning) or modify the !CORE_DUMP_USE_REGSET
code to use NT_FILE as well.

Otherwise I can't comment the patch, I simply do not know what
people do with the coredumps. But Denys certainly knows, he works
with the tools which need this info.

Oleg.