[PATCH] Staging: android: ashmem: Replaces printk with pr_err and pr_info

[PATCH] Staging: android: ashmem: Replaces printk with pr_err and pr_info

[Austin Robinson]

In several instances in ashmem.c, printk(KERN_INFO... and printk{KERN_ERR... were being
used. This replaces those with the preferred pr_err and pr_info, which removes
style-related warnings.

Signed-off-by: Austin C Robinson <austin.rbsn@gmail.com>
---
 drivers/staging/android/ashmem.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index e84dbec..01e61c9 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -707,7 +707,7 @@ static int __init ashmem_init(void)
 					  sizeof(struct ashmem_area),
 					  0, 0, NULL);
 	if (unlikely(!ashmem_area_cachep)) {
-		printk(KERN_ERR "ashmem: failed to create slab cache\n");
+		pr_err("ashmem: failed to create slab cache\n");
 		return -ENOMEM;
 	}
 
@@ -715,19 +715,19 @@ static int __init ashmem_init(void)
 					  sizeof(struct ashmem_range),
 					  0, 0, NULL);
 	if (unlikely(!ashmem_range_cachep)) {
-		printk(KERN_ERR "ashmem: failed to create slab cache\n");
+		pr_err("ashmem: failed to create slab cache\n");
 		return -ENOMEM;
 	}
 
 	ret = misc_register(&ashmem_misc);
 	if (unlikely(ret)) {
-		printk(KERN_ERR "ashmem: failed to register misc device!\n");
+		pr_err("ashmem: failed to register misc device!\n");
 		return ret;
 	}
 
 	register_shrinker(&ashmem_shrinker);
 
-	printk(KERN_INFO "ashmem: initialized\n");
+	pr_info("ashmem: initialized\n");
 
 	return 0;
 }
@@ -740,12 +740,12 @@ static void __exit ashmem_exit(void)
 
 	ret = misc_deregister(&ashmem_misc);
 	if (unlikely(ret))
-		printk(KERN_ERR "ashmem: failed to unregister misc device!\n");
+		pr_err("ashmem: failed to unregister misc device!\n");
 
 	kmem_cache_destroy(ashmem_range_cachep);
 	kmem_cache_destroy(ashmem_area_cachep);
 
-	printk(KERN_INFO "ashmem: unloaded\n");
+	pr_info("ashmem: unloaded\n");
 }
 
 module_init(ashmem_init);
-- 
1.7.11.2

Re: [PATCH] Staging: android: ashmem: Replaces printk with pr_err and pr_info

[Dan Carpenter]

On Sat, Jul 14, 2012 at 08:28:34AM -0400, Austin Robinson wrote:
> In several instances in ashmem.c, printk(KERN_INFO... and printk{KERN_ERR... were being
> used. This replaces those with the preferred pr_err and pr_info, which removes
> style-related warnings.
> 

Someone already did this.  You should be working against linux-next.

regards,
dan carpenter