linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: rob@landley.net, Ingo Molnar <mingo@redhat.com>,
	linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: uprobes: fix uprobe tracer wrong documentation
Date: Mon, 16 Jul 2012 16:46:50 +0530	[thread overview]
Message-ID: <20120716111650.GA5272@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACV3sb+mHoxLWtEGbxzGQ8Lfn2JDc5F=PNMMfmU2Ayw4-JHb+w@mail.gmail.com>

* Jovi Zhang <bookjovi@gmail.com> [2012-07-16 16:49:03]:

> From e382d2d14b8177bcd2e6bac2fee004fd1f052cb5 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Tue, 17 Jul 2012 00:35:30 +0800
> Subject: [PATCH] uprobes: fix uprobe tracer wrong documentation
> 
> The uprobe example is wrong in current kernel:
> $ echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> -bash: echo: write error: Invalid argument
> 
> It should be as following:
> $ echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events

Right, the colon is only needed if we want to provide the optional event
name.

> 
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> ---
>  Documentation/trace/uprobetracer.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/uprobetracer.txt
> b/Documentation/trace/uprobetracer.txt
> index 24ce682..8932726 100644
> --- a/Documentation/trace/uprobetracer.txt
> +++ b/Documentation/trace/uprobetracer.txt
> @@ -40,7 +40,7 @@ Usage examples
>  To add a probe as a new event, write a new definition to uprobe_events
>  as below.
> 
> -  echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> +  echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> 
>   This sets a uprobe at an offset of 0x4245c0 in the executable /bin/bash
> 
> -- 
> 1.7.9.7


       reply	other threads:[~2012-07-16 11:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CACV3sb+mHoxLWtEGbxzGQ8Lfn2JDc5F=PNMMfmU2Ayw4-JHb+w@mail.gmail.com>
2012-07-16 11:16 ` Srikar Dronamraju [this message]
2012-07-18  2:44 ` uprobes: fix uprobe tracer wrong documentation Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716111650.GA5272@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=bookjovi@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).