[PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Chen Baozi]

Fix trivial typo error that has written "It" to "Is".

Signed-off-by: Chen Baozi <baozich@gmail.com>
---
 fs/xfs/xfs_da_btree.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h
index dbf7c07..be30bd4 100644
--- a/fs/xfs/xfs_da_btree.h
+++ b/fs/xfs/xfs_da_btree.h
@@ -32,7 +32,7 @@ struct zone;
 /*
  * This structure is common to both leaf nodes and non-leaf nodes in the Btree.
  *
- * Is is used to manage a doubly linked list of all blocks at the same
+ * It is used to manage a doubly linked list of all blocks at the same
  * level in the Btree, and to identify which type of block this is.
  */
 #define XFS_DA_NODE_MAGIC	0xfebe	/* magic number: non-leaf blocks */
-- 
1.7.1

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Ben Myers]

Hey Chen,

On Sat, Jul 14, 2012 at 03:38:13AM +0800, Chen Baozi wrote:
> Fix trivial typo error that has written "It" to "Is".
> 
> Signed-off-by: Chen Baozi <baozich@gmail.com>

Reviewed-by: Ben Myers <bpm@sgi.com>

Thanks for the patch!  I'm happy you're working on XFS.  Do you have any
time/interest in taking on a work item or two?  I have a few would-be-nices
which I've made notes of, and I'm sure that Dave or Christoph could also think
of a few if you're interested.

Thanks again,
-Ben

> ---
>  fs/xfs/xfs_da_btree.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h
> index dbf7c07..be30bd4 100644
> --- a/fs/xfs/xfs_da_btree.h
> +++ b/fs/xfs/xfs_da_btree.h
> @@ -32,7 +32,7 @@ struct zone;
>  /*
>   * This structure is common to both leaf nodes and non-leaf nodes in the Btree.
>   *
> - * Is is used to manage a doubly linked list of all blocks at the same
> + * It is used to manage a doubly linked list of all blocks at the same
>   * level in the Btree, and to identify which type of block this is.
>   */
>  #define XFS_DA_NODE_MAGIC	0xfebe	/* magic number: non-leaf blocks */
> -- 
> 1.7.1
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Chen Baozi]

Hi Ben,
On Jul 16, 2012, at 11:10 PM, Ben Myers wrote:

> Hey Chen,
> 
> On Sat, Jul 14, 2012 at 03:38:13AM +0800, Chen Baozi wrote:
>> Fix trivial typo error that has written "It" to "Is".
>> 
>> Signed-off-by: Chen Baozi <baozich@gmail.com>
> 
> Reviewed-by: Ben Myers <bpm@sgi.com>
> 
> Thanks for the patch!  I'm happy you're working on XFS.  Do you have any
> time/interest in taking on a work item or two?  I have a few would-be-nices
> which I've made notes of, and I'm sure that Dave or Christoph could also think
> of a few if you're interested.
I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)， which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it. 

Thanks a lot.

Baozi
> 
> Thanks again,
> -Ben
> 
>> ---
>> fs/xfs/xfs_da_btree.h |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h
>> index dbf7c07..be30bd4 100644
>> --- a/fs/xfs/xfs_da_btree.h
>> +++ b/fs/xfs/xfs_da_btree.h
>> @@ -32,7 +32,7 @@ struct zone;
>> /*
>>  * This structure is common to both leaf nodes and non-leaf nodes in the Btree.
>>  *
>> - * Is is used to manage a doubly linked list of all blocks at the same
>> + * It is used to manage a doubly linked list of all blocks at the same
>>  * level in the Btree, and to identify which type of block this is.
>>  */
>> #define XFS_DA_NODE_MAGIC	0xfebe	/* magic number: non-leaf blocks */
>> -- 
>> 1.7.1
>> 
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Christoph Hellwig]

On Tue, Jul 17, 2012 at 11:33:33AM +0800, Chen Baozi wrote:
> I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)??? which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it. 

Btw, if you need more reviers for the syslinus support feel free to pass
it by me (or the list).

Thanks for working on this!

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Chen Baozi]

On Jul 17, 2012, at 3:06 PM, Christoph Hellwig wrote:

> On Tue, Jul 17, 2012 at 11:33:33AM +0800, Chen Baozi wrote:
>> I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)??? which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it. 
> 
> Btw, if you need more reviers for the syslinus support feel free to pass
> it by me (or the list).
Sure, thanks.
> 
> Thanks for working on this!
> 

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Jeff Liu]

On 07/17/2012 05:33 PM, Chen Baozi wrote:

> 
> On Jul 17, 2012, at 3:06 PM, Christoph Hellwig wrote:
> 
>> On Tue, Jul 17, 2012 at 11:33:33AM +0800, Chen Baozi wrote:
>>> I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)??? which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it. 
>>
>> Btw, if you need more reviers for the syslinus support feel free to pass
>> it by me (or the list).
> Sure, thanks.

Glad to see a new developer from china, Wanlong from Fujitsu has also
started working on XFS recently, we can learn together. :)
Btw, are you living in Beijing Baozi?

Thanks,
-Jeff

>>
>> Thanks for working on this!
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Chen Baozi]

On Jul 17, 2012, at 9:11 PM, Jeff Liu wrote:

> On 07/17/2012 05:33 PM, Chen Baozi wrote:
> 
>> 
>> On Jul 17, 2012, at 3:06 PM, Christoph Hellwig wrote:
>> 
>>> On Tue, Jul 17, 2012 at 11:33:33AM +0800, Chen Baozi wrote:
>>>> I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)??? which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it. 
>>> 
>>> Btw, if you need more reviers for the syslinus support feel free to pass
>>> it by me (or the list).
>> Sure, thanks.
> 
> Glad to see a new developer from china, Wanlong from Fujitsu has also
> started working on XFS recently, we can learn together. :)
> Btw, are you living in Beijing Baozi?
Oh, no. I'm still a master student in Changsha, :-) 
> 
> Thanks,
> -Jeff
> 
>>> 
>>> Thanks for working on this!
>>> 
>> 
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
> 
> 

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Paulo Alcantara]

From: Christoph Hellwig <hch@infradead.org>
Date: Tue, 17 Jul 2012 03:06:43 -0400

> Btw, if you need more reviers for the syslinus support feel free to pass
> it by me (or the list).

This is the branch I'm maintaing for the XFS readonly driver:

git://zytor.com/users/pcacjr/syslinux.git (branch: xfs)

The current status is:

    - We are able to find the root inode by reading rootino field from
      superblock (xfs_iget_root() function).
    - We are able to find inodes that have core's format set to "local" only at
      the moment, which is by reading leaf entries from inode btrees. The
      function that looks up for an inode is the xfs_iget() one. We're looking
      forward to implement the handling of keys in inode btrees (extents) also.

Baoszi is currently working on the inode btree's key part (extents), and I'm
working on the data part of the file inode, which is the xfs_next_extent()
function.

The xfs_next_extent() function must be able to read the inode (cast to the data
fork) and populate a structure that stores physical starting number sector and
number of consecutive sectors that contain the inode's data so that Syslinux
will know where to read from.

Thanks for the interest in helping us!


		Paulo

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

[Dave Chinner]

On Tue, Jul 17, 2012 at 10:40:21PM -0300, Paulo Alcantara wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Tue, 17 Jul 2012 03:06:43 -0400
> 
> > Btw, if you need more reviers for the syslinus support feel free to pass
> > it by me (or the list).
> 
> This is the branch I'm maintaing for the XFS readonly driver:
> 
> git://zytor.com/users/pcacjr/syslinux.git (branch: xfs)
> 
> The current status is:
> 
>     - We are able to find the root inode by reading rootino field from
>       superblock (xfs_iget_root() function).
>     - We are able to find inodes that have core's format set to "local" only at
>       the moment, which is by reading leaf entries from inode btrees. The
>       function that looks up for an inode is the xfs_iget() one. We're looking
>       forward to implement the handling of keys in inode btrees (extents) also.
> 
> Baoszi is currently working on the inode btree's key part (extents), and I'm
> working on the data part of the file inode, which is the xfs_next_extent()
> function.
> 
> The xfs_next_extent() function must be able to read the inode (cast to the data
> fork) and populate a structure that stores physical starting number sector and
> number of consecutive sectors that contain the inode's data so that Syslinux
> will know where to read from.

As we discussed on #xfs, I'm still not convinced that parsing the
filesystem metadata in the bootloader is the way to go. Far better,
IMO, is simply to supply the bootloader with a list of extents for
the blocks it needs to read to get the files it needs. You can get
them via fiemap(), and it'll work for XFS, btrfs, ext3, ext4, etc
without needing to write code to parse the on-disk format of every
filesystem.

Especially as we are in the process of making major changes to the
XFS on-disk format, which means you'll have to make significant
changes to support a second XFS disk format in the not-to-distant
future...

> Thanks for the interest in helping us!

We want it to work! ;)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com