From: "Theodore Ts'o" <tytso@mit.edu>
To: Rob Landley <rob@landley.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
rgetz@blackfin.uclinux.org, mpm@selenic.com
Subject: Re: feature-removal-schedule entry from 2009
Date: Mon, 16 Jul 2012 11:21:40 -0400 [thread overview]
Message-ID: <20120716152140.GA27656@thunk.org> (raw)
In-Reply-To: <50032B11.7070505@landley.net>
On Sun, Jul 15, 2012 at 03:41:53PM -0500, Rob Landley wrote:
> Does it become a "please add a call to sample_interrupt_randomness()"
> reminder, or will the infrastructure figure out when to do that outside
> the driver?
The patches in the random.git tree unconditionally call
add_interrupt_randomness() in handle_irq_event_percpu(), so the
drivers don't need to do anything at this point.
> And will this upcoming patch set remove 'em, or leave the NOP debris
> there?
The current status is here:
http://git.kernel.org/?p=linux/kernel/git/tytso/random.git;a=summary
At this point the flag is a no-op, and can be removed. This close to
the merge window, I don't think I'm going to have time to create
patches which remove the flag from all of the drivers, but it's
basically clean up work, and having the extra bit set isn't going to
harm anyone.
The only thing that might require a bit of care is the usage in
arch/um, where someone needs to do a bit more analysis to see if it's
just a matter of removing the flag from the call to request_irq(). My
current thinking was to merge the new interrupt structure during this
merge window, and then clean up the NOP debris during the next
development cycle.
- Ted
prev parent reply other threads:[~2012-07-16 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 16:15 feature-removal-schedule entry from 2009 Rob Landley
2012-07-13 3:03 ` Theodore Ts'o
2012-07-15 20:41 ` Rob Landley
2012-07-16 15:21 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716152140.GA27656@thunk.org \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rgetz@blackfin.uclinux.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox