From: Arnd Bergmann <arnd@arndb.de>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linux-samsung-soc@vger.kernel.org,
santoshsy@gmail.com, arnd@linaro.org,
girish.shivananjappa@linaro.org, saugata.das@linaro.org,
vishak.g@samsung.com, venkat@linaro.org, k.rajesh@samsung.com,
dsaxena@linaro.org, ilho215.lee@samsung.com, nala.la@samsung.com,
sreekumar.c@samsung.com
Subject: Re: [PATCH V2 0/4] [SCSI] ufs: Adds glue drivers to ufshcd
Date: Mon, 16 Jul 2012 16:22:23 +0000 [thread overview]
Message-ID: <201207161622.24063.arnd@arndb.de> (raw)
In-Reply-To: <1342447217.3176.22.camel@dabdike.int.hansenpartnership.com>
On Monday 16 July 2012, James Bottomley wrote:
> On Fri, 2012-07-13 at 15:45 +0000, Arnd Bergmann wrote:
> > On Friday 13 July 2012, Vinayak Holikatti wrote:
> > > This patch set adds following features
> > > - Seprates PCI specific code from ufshcd.c to make it as core
> > > - Adds PCI glue driver ufshcd-pci.c
> > > - Adds Platform glue driver ufshcd-pltfrm.c
> > > - Update correct transfer size in Command UPIU
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I need a maintainer ack for this to go upstream.
>
> Also, looking at this, I think this patch series isn't bisectable:
> Patch 1 removes PCI support and patch 2 adds it back in a different
> form. However, any PCI based UFS system would stop working if the
> bisect landed at patch 1. I think you can fix this just by combining
> patches 1 and 2.
I suggested to split the patch in two in a private review that we
did on the linaro mailing list. I gave my Ack because the split
was done, but I failed to notice that it was done differently
from what I suggested in
On Monday 02 July 2012, Arnd Bergmann wrote:
> I would recommend that you split this patch into two separate
> changesets, where you do all the changes to existing code in the
> first patch, and only move but don't change code in the second one
> that creates the new file.
I agree that breaking bisectibility by ripping out the PCI code
first is not good. The version 2 is not actually easier to review
at all than the first version, it just splits the changes by
file, which is pointless.
Arnd
next prev parent reply other threads:[~2012-07-16 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 14:07 [PATCH V2 0/4] [SCSI] ufs: Adds glue drivers to ufshcd Vinayak Holikatti
2012-07-13 14:07 ` [PATCH V2 1/4] [SCSI] drivers/scsi/ufs: Remove PCI specific code Vinayak Holikatti
2012-07-13 15:45 ` [PATCH V2 0/4] [SCSI] ufs: Adds glue drivers to ufshcd Arnd Bergmann
2012-07-16 14:00 ` James Bottomley
2012-07-16 16:22 ` Arnd Bergmann [this message]
2012-07-19 11:29 ` vinayak holikatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207161622.24063.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@linaro.org \
--cc=dsaxena@linaro.org \
--cc=girish.shivananjappa@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=k.rajesh@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nala.la@samsung.com \
--cc=patches@linaro.org \
--cc=santoshsy@gmail.com \
--cc=saugata.das@linaro.org \
--cc=sreekumar.c@samsung.com \
--cc=venkat@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox