public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Grant Likely <grant.likely@secretlab.ca>,
	"Linux-sh list" <linux-sh@vger.kernel.org>
Subject: [RFC][PATCH 14/14] ARM: shmobile: Add support for storing PM domain information in DTs
Date: Mon, 16 Jul 2012 23:32:16 +0200	[thread overview]
Message-ID: <201207162332.16328.rjw@sisk.pl> (raw)
In-Reply-To: <201207162315.49073.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Allow the common power management support code for Renesas SoCs to
read the names of the power domains that platform devices belong to
from a device tree describing the platform.

The name of the power domain is stored within the given device's DT
node as a case-sensitive string attribute of the name
"renesas,pmdomain".  The values of those attributes are read by the
platform code throuch a platform bus type notifier which is executed
right after adding the device to the device hierarchy and are then
used for adding devices to the given PM domains with the help of
pm_genpd_name_add_device().

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/arm/mach-shmobile/pm-rmobile.c |   92 ++++++++++++++++++++++++++++++++----
 1 file changed, 83 insertions(+), 9 deletions(-)

Index: linux/arch/arm/mach-shmobile/pm-rmobile.c
===================================================================
--- linux.orig/arch/arm/mach-shmobile/pm-rmobile.c
+++ linux/arch/arm/mach-shmobile/pm-rmobile.c
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2012  Renesas Solutions Corp.
  * Copyright (C) 2012  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+ * Copyright (C) 2012  Rafael J. Wysocki <rjw@sisk.pl>
  *
  * based on pm-sh7372.c
  *  Copyright (C) 2011 Magnus Damm
@@ -13,7 +14,9 @@
  */
 #include <linux/console.h>
 #include <linux/delay.h>
+#include <linux/notifier.h>
 #include <linux/platform_device.h>
+#include <linux/of_platform.h>
 #include <linux/pm.h>
 #include <linux/pm_clock.h>
 #include <asm/io.h>
@@ -149,21 +152,92 @@ static void rmobile_init_pm_domain(struc
 	__rmobile_pd_power_up(rmobile_pd, false);
 }
 
-void rmobile_init_domains(struct rmobile_pm_domain domains[], int num)
-{
-	int j;
-
-	for (j = 0; j < num; j++)
-		rmobile_init_pm_domain(&domains[j]);
-}
-
 void rmobile_add_device_to_domain(const char *domain_name,
 				 struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
+	int ret;
 
-	pm_genpd_name_add_device(domain_name, dev);
+	do
+		ret = pm_genpd_name_add_device(domain_name, dev);
+	while (ret == -EAGAIN);
 	if (pm_clk_no_clocks(dev))
 		pm_clk_add(dev, NULL);
 }
+
+#ifdef CONFIG_USE_OF
+
+static void rmobile_read_domain_from_dt(struct device *dev)
+{
+	const char *domain_name;
+	int ret;
+
+	ret = of_property_read_string(dev->of_node, "renesas,pmdomain",
+				      &domain_name);
+	if (!ret)
+		rmobile_add_device_to_domain(domain_name,
+					     to_platform_device(dev));
+}
+
+static void rmobile_remove_from_domain(struct device *dev)
+{
+	struct generic_pm_domain *genpd = dev_to_genpd(dev);
+	int ret;
+
+	/*
+	 * The check below takes care of the situations in which the device's
+	 * pm_domain pointer contains a valid address, but that is not an
+	 * address of a generic PM domain object.
+	 */
+	if (pm_genpd_present(genpd)) {
+		do
+			ret = pm_genpd_remove_device(genpd, dev);
+		while (ret == -EAGAIN);
+	}
+}
+
+static int rmobile_pm_notifier_call(struct notifier_block *nb,
+				    unsigned long event, void *data)
+{
+	struct device *dev = data;
+
+	switch (event) {
+	case BUS_NOTIFY_ADD_DEVICE:
+		if (dev->of_node)
+			rmobile_read_domain_from_dt(dev);
+
+		break;
+
+	case BUS_NOTIFY_DEL_DEVICE:
+		rmobile_remove_from_domain(dev);
+
+		break;
+	}
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block platform_nb = {
+	.notifier_call = rmobile_pm_notifier_call,
+};
+
+static void rmobile_add_bus_notifier_for_domains(void)
+{
+	bus_register_notifier(&platform_bus_type, &platform_nb);
+}
+
+#else
+
+static inline void rmobile_add_bus_notifier_for_domains(void) {}
+
+#endif /* CONFIG_USE_OF */
+
+void rmobile_init_domains(struct rmobile_pm_domain domains[], int num)
+{
+	int j;
+
+	for (j = 0; j < num; j++)
+		rmobile_init_pm_domain(&domains[j]);
+
+	rmobile_add_bus_notifier_for_domains();
+}
 #endif /* CONFIG_PM */


  parent reply	other threads:[~2012-07-16 21:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 21:02 [RFD] PM: Device tree representation of power domains Rafael J. Wysocki
2012-07-04 11:56 ` Mark Brown
2012-07-05 20:17   ` Rafael J. Wysocki
2012-07-16 21:15     ` [RFC][PATCH 0/14] PM / shmobile: Pass power domain information via DT (was: Re: [RFD] PM: Device tree representation of power domains) Rafael J. Wysocki
2012-07-16 21:17       ` [RFC][PATCH 1/14] PM / Domains: Make it possible to use domain names when adding devices Rafael J. Wysocki
2012-07-16 21:18       ` [RFC][PATCH 2/14] ARM: shmobile: Use names of power domains for adding devices to them Rafael J. Wysocki
2012-07-16 21:19       ` [RFC][PATCH 3/14] ARM: shmobile: Drop r8a7779_add_device_to_domain() Rafael J. Wysocki
2012-07-16 21:20       ` [RFC][PATCH 4/14] PM / Domains: Make it possible to use names when adding subdomains Rafael J. Wysocki
2012-07-16 21:21       ` [RFC][PATCH 5/14] ARM: shmobile: Use domain names when adding subdomains to power domains Rafael J. Wysocki
2012-07-16 21:23       ` [RFC][PATCH 6/14] RM: shmobile: Add routine for automatic PM domains initialization Rafael J. Wysocki
2012-07-16 21:24       ` [RFC][PATCH 7/14] ARM: shmobile: Remove dead sh7372 power management code Rafael J. Wysocki
2012-07-16 21:25       ` [RFC][PATCH 8/14] PM / Domains: Add power-on function using names to identify domains Rafael J. Wysocki
2012-07-16 21:26       ` [RFC][PATCH 9/14] ARM: shmobile: Move sh7372's PM domain objects to a table Rafael J. Wysocki
2012-07-16 21:27       ` [RFC][PATCH 10/14] ARM: shmobile: Move r8a7740's " Rafael J. Wysocki
2012-07-16 21:28       ` [RFC][PATCH 11/14] ARM: shmobile: Move r8a7779's " Rafael J. Wysocki
2012-07-16 21:29       ` [RFC][PATCH 12/14] ARM: shmobile: Make rmobile_init_pm_domain() static Rafael J. Wysocki
2012-07-16 21:30       ` [RFC][PATCH 13/14] PM / Domains: Introduce pm_genpd_present() Rafael J. Wysocki
2012-07-16 21:32       ` Rafael J. Wysocki [this message]
2012-07-21 17:17       ` [RFC][PATCH 0/14] PM / shmobile: Pass power domain information via DT (was: Re: [RFD] PM: Device tree representation of power domains) Rafael J. Wysocki
2012-07-24 15:20         ` Arnd Bergmann
2012-07-24 19:34           ` Rafael J. Wysocki
2012-07-24 19:56             ` Arnd Bergmann
2012-07-24 20:37               ` Rafael J. Wysocki
2012-07-25  9:29                 ` Rafael J. Wysocki
2012-07-25 13:00                 ` Arnd Bergmann
2012-07-25 22:32                   ` Rafael J. Wysocki
2012-07-26  0:38                     ` Kevin Hilman
2012-07-26 20:55                       ` Rafael J. Wysocki
2012-07-26 21:09                       ` Mark Brown
2012-07-26 21:34                         ` Rafael J. Wysocki
2012-07-26 21:45                         ` Kevin Hilman
2012-07-26 21:55                           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207162332.16328.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox