public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: James.Bottomley@HansenPartnership.com,
	mdharm-usb@one-eyed-alien.net, stern@rowland.harvard.edu,
	sshtylyov@mvista.com, bvanassche@acm.org,
	akpm@linux-foundation.org, linux-usb@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.
Date: Mon, 16 Jul 2012 16:48:05 -0700	[thread overview]
Message-ID: <20120716234805.GA9875@kroah.com> (raw)
In-Reply-To: <1341716685-6631-1-git-send-email-linkinjeon@gmail.com>

On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> The numbers of USB HDDs(All USB HDD I checked) does not respond
> correctly to scsi mode sense command for retrieving the write cache
> page status. Even though write cache is enabled by default, due to
> scsi driver assume that cache is not enabled which in turn might lead
> to loss of data since data still will be in cache.
> This result that all filesystems is not stable on USB HDD when the
> device is unplugged abruptly, even though these are having journaling
> feature. Our first trying is that scsi driver send ATA command
> (ATA Pass through, #85) to USB HDD after failure from normal routine to
> know write cache enable.
> We have known it is dangerous after testing several USB HDD. some of
> HDD is stalled by this command(A-DATA HDD). So we tried to make the
> patch James Bottomley's suggestion(usb quirk) on version 2 that add
> product ID and verdor ID of USB HDD to USB quirk list after checking
> write cache.
> All filesystem will be stable on USB HDD registered in quirk list.
> And it will be updated continuously.

Now applied to the usb-next branch.

thanks,

greg k-h

  reply	other threads:[~2012-07-16 23:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-08  3:04 [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd Namjae Jeon
2012-07-16 23:48 ` Greg KH [this message]
2012-07-17  7:19   ` James Bottomley
2012-07-17 15:46     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716234805.GA9875@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=bvanassche@acm.org \
    --cc=linkinjeon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=namjae.jeon@samsung.com \
    --cc=sshtylyov@mvista.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox