Re: [PATCH v2] staging: sbe-2t3e3: Remove code that will never execute

Greg KH
2012-07-17T02:11:13Z

On Thu, Jul 12, 2012 at 11:27:49PM -0300, Marcos Paulo de Souza wrote:
> This patch removes all references of "if 0" blocks in the sbe-2t3e3 driver.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
> drivers/staging/sbe-2t3e3/2t3e3.h | 3 --
> drivers/staging/sbe-2t3e3/cpld.c | 15 ---------
> drivers/staging/sbe-2t3e3/ctrl.c | 19 +++--------
> drivers/staging/sbe-2t3e3/dc.c | 17 ----------
> drivers/staging/sbe-2t3e3/exar7250.c | 40 +++--------------------
> drivers/staging/sbe-2t3e3/exar7300.c | 17 ----------
> drivers/staging/sbe-2t3e3/intr.c | 60 ++--------------------------------
> drivers/staging/sbe-2t3e3/io.c | 21 ------------
> 8 files changed, 10 insertions(+), 182 deletions(-)
>
> diff --git a/drivers/staging/sbe-2t3e3/2t3e3.h b/drivers/staging/sbe-2t3e3/2t3e3.h
> index fe9f086..383f2cf 100644
> --- a/drivers/staging/sbe-2t3e3/2t3e3.h
> +++ b/drivers/staging/sbe-2t3e3/2t3e3.h
>
> Just fix the commit message fo sbr-2t3e3 to sbe-2t3e3.
>
> @@ -801,9 +801,6 @@ u32 cpld_read(struct channel *sc, u32 reg);

Woah, what is that line in the middle of the patch here? That causes
git to (rightfully) choke on the patch.

Please fix this and resend.

thanks,

greg k-h