Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

Chen Baozi
2012-07-17T03:33:47Z

Hi Ben,
On Jul 16, 2012, at 11:10 PM, Ben Myers wrote:

> Hey Chen,
>
> On Sat, Jul 14, 2012 at 03:38:13AM +0800, Chen Baozi wrote:
>> Fix trivial typo error that has written "It" to "Is".
>>
>> Signed-off-by: Chen Baozi <baozich@gmail.com>
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
>
> Thanks for the patch! I'm happy you're working on XFS. Do you have any
> time/interest in taking on a work item or two? I have a few would-be-nices
> which I've made notes of, and I'm sure that Dave or Christoph could also think
> of a few if you're interested.
I'd really love to. Right now, I am working on syslinux to support booting on xfs partition (under pcacjr's mentoring)， which I thought would be a nice start to get familiar with xfs (and I did learn a lot from it). So I think there would be more time (and experience on xfs) after I finish the xfs support on syslinux. And I'm really looking forward to your ideas. So do please tell me what I can help, I'll try my best to do it.

Thanks a lot.

Baozi
>
> Thanks again,
> -Ben
>
>> ---
>> fs/xfs/xfs_da_btree.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_da_btree.h b/fs/xfs/xfs_da_btree.h
>> index dbf7c07..be30bd4 100644
>> --- a/fs/xfs/xfs_da_btree.h
>> +++ b/fs/xfs/xfs_da_btree.h
>> @@ -32,7 +32,7 @@ struct zone;
>> /*
>> * This structure is common to both leaf nodes and non-leaf nodes in the Btree.
>> *
>> - * Is is used to manage a doubly linked list of all blocks at the same
>> + * It is used to manage a doubly linked list of all blocks at the same
>> * level in the Btree, and to identify which type of block this is.
>> */
>> #define XFS_DA_NODE_MAGIC 0xfebe /* magic number: non-leaf blocks */
>> --
>> 1.7.1
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs