Re: uprobe: checking probe event include directory

[Frederic Weisbecker <fweisbec@gmail.com>]

On Tue, Jul 17, 2012 at 06:12:28PM +0800, Jovi Zhang wrote:
> From 16ed13ee9098ae01705e8456005d1ad6d9909128 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Wed, 18 Jul 2012 01:16:23 +0800
> Subject: [PATCH] uprobe: checking probe event include directory
> 
> Currently below command run successful:
> $ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> 
> this don't make sense, because /bin is a directory,
> so make this checking earily, not report error untill probe enable.
> 
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>

Adding Srikar in Cc.

> ---
>  kernel/trace/trace_uprobe.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 85158fa..cf382de 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -259,6 +259,11 @@ static int create_trace_uprobe(int argc, char **argv)
>  		goto fail_address_parse;
> 
>  	inode = igrab(path.dentry->d_inode);
> +	 if (S_ISDIR(inode->i_mode)) {
> +		ret = -EINVAL;
> +		pr_info("probe file cannot be directory.\n");
> +		goto fail_address_parse;
> +	}
> 
>  	argc -= 2;
>  	argv += 2;
> -- 
> 1.7.9.7