From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Linux PM list" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
markgross@thegnar.org, "Matthew Garrett" <mjg@redhat.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"John Stultz" <john.stultz@linaro.org>,
"Brian Swetland" <swetland@google.com>,
"Neil Brown" <neilb@suse.de>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
mtk@lwn.net
Subject: Re: [patch] Rename CAP_EPOLLWAKEUP to CAL_BLOCK_SUSPEND
Date: Tue, 17 Jul 2012 13:59:14 +0000 [thread overview]
Message-ID: <20120717135914.GA6662@mail.hallyn.com> (raw)
In-Reply-To: <CAKgNAkh=LpuQDYWJ1XZpLMv+oFNqUD2Y+ZAxKOyB08-1OkJ55A@mail.gmail.com>
Quoting Michael Kerrisk (man-pages) (mtk.manpages@gmail.com):
> On Tue, Jul 17, 2012 at 3:46 PM, Serge E. Hallyn <serge@hallyn.com> wrote:
> > Quoting Michael Kerrisk (mtk.manpages@gmail.com):
> >> Rafael,
> >>
> >> As discussed in
> >> http://thread.gmane.org/gmane.linux.kernel/1249726/focus=1288990,
> >> the capability introduced in 4d7e30d98939a0340022ccd49325a3d70f7e0238
> >> to govern EPOLLWAKEUP seems misnamed: this capability is about governing
> >> the ability to suspend the system, not using a particular API flag
> >> (EPOLLWAKEUP). We should make the name of the capability more general
> >> to encourage reuse in related cases. (Whether or not this capability
> >> should also be used to govern the use of /sys/power/wake_lock is a
> >> question that needs to be separately resolved.)
> >>
> >> This patch renames the capability to CAP_BLOCK_SUSPEND. In order to ensure
> >> that the old capability name doesn't make it out into the wild, could you
> >> please apply and push up the tree to ensure that it is incorporated
> >> for the 3.5 release.
> >>
> >> Thanks,
> >>
> >> Michael
> >>
> >> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
> >
> > I definately like that name better, thanks. Don't know if renaming it
> > without an alias could cause trouble for some bleeding edge userspaces?
> > Would it be worth keeping the
> >
> > #define CAP_EPOLLWAKEUP 36
> >
> > line? If this is deemed early enough I do prefer not to complicate with
> > a duplicate name.
>
> Maybe I'm too ignorant. Are there userspaces that bleed with the -rc
> series? I'd have thought this renaming would be a fairly safe change
> at this point.
I'm sure there are, but I'm not sure what we've promised them.
Like I say if at all possible I do prefer not to keep CAP_EPOLLWAKEUP.
-serge
next prev parent reply other threads:[~2012-07-17 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 4:37 [patch] Rename CAP_EPOLLWAKEUP to CAL_BLOCK_SUSPEND Michael Kerrisk
2012-07-17 13:46 ` Serge E. Hallyn
2012-07-17 13:54 ` Michael Kerrisk (man-pages)
2012-07-17 13:59 ` Serge E. Hallyn [this message]
2012-07-17 19:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717135914.GA6662@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=arve@android.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=markgross@thegnar.org \
--cc=mjg@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=mtk@lwn.net \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox