From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org, olaf@aepfle.de, apw@canonical.com
Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
Date: Tue, 17 Jul 2012 09:04:02 -0700 [thread overview]
Message-ID: <20120717160402.GA20481@kroah.com> (raw)
In-Reply-To: <1342298060-12662-1-git-send-email-kys@microsoft.com>
On Sat, Jul 14, 2012 at 01:34:06PM -0700, K. Y. Srinivasan wrote:
> Format GUIDS as per MSFT standard. This makes interacting with MSFT
> tool stack easier.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> drivers/hv/vmbus_drv.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index a220e57..1f7e54a 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device *dev,
>
> if (!strcmp(dev_attr->attr.name, "class_id")) {
> ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> - "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> + "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
As Joe pointed out, please just use the printk modifier the kernel
already has for GUIDS, and don't roll your own here. That will work
properly for you, right?
thanks,
greg k-h
next prev parent reply other threads:[~2012-07-17 16:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 20:32 [PATCH 00/15] drivers: hv: kvp K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards K. Y. Srinivasan
2012-07-14 20:24 ` Joe Perches
2012-07-14 23:23 ` KY Srinivasan
2012-07-14 23:28 ` Joe Perches
2012-07-14 20:34 ` [PATCH 02/15] Drivers: hv: Add KVP definitions for IP address injection K. Y. Srinivasan
2012-07-17 4:09 ` Olaf Hering
2012-07-17 16:05 ` Greg KH
2012-07-17 17:39 ` KY Srinivasan
2012-07-14 20:34 ` [PATCH 03/15] Drivers: hv: kvp: Cleanup error handling in KVP K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 04/15] Drivers: hv: kvp: Support the new IP injection messages K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 05/15] Tools: hv: Prepare to expand kvp_get_ip_address() functionality K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 06/15] Tools: hv: Further refactor kvp_get_ip_address() K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 07/15] Tools: hv: Gather address family information K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 08/15] Tools: hv: Gather subnet information K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 09/15] Tools: hv: Represent the ipv6 mask using CIDR notation K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 10/15] Tools: hv: Gather ipv[4,6] gateway information K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 11/15] Tools: hv: Gather DNS information K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 12/15] Tools: hv: Gather DHCP information K. Y. Srinivasan
2012-07-14 21:36 ` richard -rw- weinberger
2012-07-14 23:02 ` KY Srinivasan
2012-07-14 23:04 ` richard -rw- weinberger
2012-07-14 20:34 ` [PATCH 13/15] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 14/15] Tools: hv: Rename the function kvp_get_ip_address() K. Y. Srinivasan
2012-07-14 20:34 ` [PATCH 15/15] Tools: hv: Implement the KVP verb - KVP_OP_GET_IP_INFO K. Y. Srinivasan
2012-07-17 16:04 ` Greg KH [this message]
2012-07-17 16:19 ` [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards Joe Perches
2012-07-17 16:32 ` Greg KH
2012-07-17 17:42 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717160402.GA20481@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).