From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org,
Arnd Bergmann <arnd@arndb.de>,
patches@linaro.org, Marco Stornelli <marco.stornelli@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, arve@android.com,
Jesper Juhl <jj@chaosbits.net>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
Rebecca Schultz Zavin <rebecca@android.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-team@android.com, Thomas Meyer <thomas@m3y3r.de>
Subject: Re: [PATCH 7/8] pstore/ram: Make tracing log versioned
Date: Tue, 17 Jul 2012 11:09:18 -0700 [thread overview]
Message-ID: <20120717180918.GA18671@lizard> (raw)
In-Reply-To: <20120717165601.GA16001@kroah.com>
On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote:
[...]
> That's nice, but it breaks the build on my system as linux_banner
> somehow isn't enabled as part of the build?
I really don't see how you managed to disable it. :-)
init/version.c is built unconditionally, and it has
'const char linux_banner[]' unconditionally. Then ram.c includes
kernel.h, which unconditionally (well, under #ifdef __KERNEL__)
includes printk.h, which has 'extern const char linux_banner[];'
prototype...
I'm still looking further, but can you please send your config
file? And may be gcc version?
p.s. While investigating this, I found that quite a lot of includes
are missing in pstore headers, and I was able to trigger at least
one issue. The patch will follow.
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-07-17 18:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 0:10 [PATCH v4 0/8] Function tracing support for pstore Anton Vorontsov
2012-07-10 0:10 ` [PATCH 1/8] tracing: Fix initialization failure path in tracing_set_tracer() Anton Vorontsov
2012-07-10 0:10 ` [PATCH 2/8] pstore: Introduce write_buf backend callback Anton Vorontsov
2012-07-10 0:10 ` [PATCH 3/8] pstore: Add persistent function tracing Anton Vorontsov
2012-07-17 19:38 ` Steven Rostedt
2012-07-17 20:01 ` Anton Vorontsov
2012-07-17 21:38 ` Steven Rostedt
2012-07-17 22:06 ` Anton Vorontsov
2012-07-18 3:47 ` [PATCH] pstore/ftrace: Convert to its own enable/disable debugfs knob Anton Vorontsov
2012-07-18 7:26 ` Anton Vorontsov
2012-07-18 13:13 ` Steven Rostedt
2012-07-18 13:10 ` Steven Rostedt
2012-07-18 18:24 ` [PATCH v2] " Anton Vorontsov
2012-07-18 17:12 ` [PATCH] " Stephen Boyd
2012-07-18 18:50 ` Anton Vorontsov
2012-07-18 18:59 ` Stephen Boyd
2012-07-18 19:30 ` [PATCH v3] " Anton Vorontsov
2012-08-21 1:46 ` Anton Vorontsov
2012-08-22 1:07 ` Steven Rostedt
2012-08-22 2:10 ` Anton Vorontsov
2012-08-22 2:25 ` Steven Rostedt
2012-07-10 0:10 ` [PATCH 4/8] tracing/function: Introduce persistent trace option Anton Vorontsov
2012-07-10 12:58 ` Steven Rostedt
2012-07-10 0:10 ` [PATCH 5/8] pstore/ram: Convert to write_buf callback Anton Vorontsov
2012-07-10 0:10 ` [PATCH 6/8] pstore/ram: Add ftrace messages handling Anton Vorontsov
2012-07-10 0:10 ` [PATCH 7/8] pstore/ram: Make tracing log versioned Anton Vorontsov
2012-07-17 16:56 ` Greg Kroah-Hartman
2012-07-17 17:09 ` Anton Vorontsov
2012-07-17 18:09 ` Anton Vorontsov [this message]
2012-07-17 18:13 ` [PATCH] pstore: Headers should include all stuff they use Anton Vorontsov
2012-07-17 18:19 ` Greg Kroah-Hartman
2012-07-17 18:37 ` Anton Vorontsov
2012-07-17 19:15 ` Greg Kroah-Hartman
2012-07-17 18:18 ` [PATCH 7/8] pstore/ram: Make tracing log versioned Greg Kroah-Hartman
2012-07-17 19:11 ` [PATCH fixed] " Anton Vorontsov
2012-07-10 0:10 ` [PATCH 8/8] tracing/function: Convert func_set_flag() to a switch statement Anton Vorontsov
2012-07-10 12:01 ` [PATCH v4 0/8] Function tracing support for pstore Arnd Bergmann
2012-07-10 13:00 ` Steven Rostedt
2012-07-16 7:14 ` Anton Vorontsov
2012-07-16 14:53 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717180918.GA18671@lizard \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=rebecca@android.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).