linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Fr?d?ric Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uprobe: fix misleading log entry
Date: Wed, 18 Jul 2012 14:52:52 +0530	[thread overview]
Message-ID: <20120718092252.GD5006@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACV3sbL2gRjoFi8yyUW6Bu2ZZ4PW+ytZsfx_65KA8s_5DEB+ZQ@mail.gmail.com>

* Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:

> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Wed, 18 Jul 2012 17:51:26 +0800
> Subject: [PATCH] uprobe: fix misleading log entry
> 
> There don't have any 'r' prefix in uprobe event naming, remove it.
> 
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> ---
>  kernel/trace/trace_uprobe.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index cf382de..852a584 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>  	if (argv[0][0] == '-')
>  		is_delete = true;
>  	else if (argv[0][0] != 'p') {
> -		pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> +		pr_info("Probe definition must be started with 'p' or '-'.\n");
>  		return -EINVAL;
>  	}
> 

Yes, uprobes doesnt support return probes. So we should not have
mentioned about r.

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>


  reply	other threads:[~2012-07-18  9:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
2012-07-18  9:22 ` Srikar Dronamraju [this message]
2012-07-18 11:43   ` Jovi Zhang
2012-07-18 15:24     ` Anton Arapov
2012-10-12  0:06   ` Jovi Zhang
2012-10-12  4:50     ` Srikar Dronamraju
2012-10-25 14:12 ` Oleg Nesterov
2012-11-19 10:42   ` Steven Rostedt
2012-11-19 12:32     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718092252.GD5006@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=bookjovi@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).