linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: rdunlap@xenotime.net, sfr@canb.auug.org.au,
	sameo@linux.intel.com, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
Date: Wed, 18 Jul 2012 10:44:49 +0100	[thread overview]
Message-ID: <20120718094449.GA22739@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1342593663-23938-1-git-send-email-anilkumar@ti.com>

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote:
> Fixes below build error if CONFIG_REGULATOR is not enabled.
> 
> drivers/built-in.o: In function `tps65217_probe':
> tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'

This isn't a patch to the regulator driver, this is a patch to the MFD.
Normally this would be fixed by making the MFD driver not depend on the
regulator API - why is the MFD driver using the regulator API?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-07-18  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  6:41 [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled AnilKumar Ch
2012-07-18  9:44 ` Mark Brown [this message]
2012-07-18  9:55   ` AnilKumar, Chimata
2012-07-18 10:00     ` Mark Brown
2012-07-19 12:35       ` AnilKumar, Chimata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718094449.GA22739@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=anilkumar@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).