From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754991Ab2GRQci (ORCPT ); Wed, 18 Jul 2012 12:32:38 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44634 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754963Ab2GRQce (ORCPT ); Wed, 18 Jul 2012 12:32:34 -0400 Date: Wed, 18 Jul 2012 09:32:29 -0700 From: Tejun Heo To: Aristeu Rozanski Cc: linux-kernel@vger.kernel.org, Li Zefan , Hugh Dickins , Hillf Danton Subject: Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory Message-ID: <20120718163229.GH24336@google.com> References: <20120702142925.795007114@napanee.usersys.redhat.com> <20120702142926.405632285@napanee.usersys.redhat.com> <20120709171748.GD1341@google.com> <20120709172220.GE1341@google.com> <20120709172831.GF1341@google.com> <20120710192721.GB19791@redhat.com> <20120717183851.GA24336@google.com> <20120717212926.GB26916@redhat.com> <20120717214010.GF24336@google.com> <20120718141604.GC26916@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120718141604.GC26916@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote: > > Yeah, generally looks good to me although @added/removed_bits argument > > names irk me a bit. The name may be okay for local variables but I > > keep thinking "what bits?". @subsys_mask or something indicating that > > it's mask of subsystems would better. Also, can you please add /** > > function comment explaining the clear/populate functions and their > > arguments? > > agreed. although the "_bits" thing is spread all around the code. you > want that cleaned up too? (I can post a followup patch after this > patchset is done) Yeah, that would be great. Thanks a lot! -- tejun