From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <abbotti@mev.co.uk>,
<gregkh@linuxfoundation.org>
Subject: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach
Date: Wed, 18 Jul 2012 18:30:48 -0700 [thread overview]
Message-ID: <201207181830.48668.hartleys@visionengravers.com> (raw)
Use pci_is_enabled() in the "find pci device" function to determine if
the found pci device is not in use and move the comedi_pci_enable() call
into the attach.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/comedi/drivers/adv_pci1723.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1723.c b/drivers/staging/comedi/drivers/adv_pci1723.c
index f561a2a..e971fa6 100644
--- a/drivers/staging/comedi/drivers/adv_pci1723.c
+++ b/drivers/staging/comedi/drivers/adv_pci1723.c
@@ -302,11 +302,7 @@ static struct pci_dev *pci1723_find_pci_dev(struct comedi_device *dev,
}
if (pcidev->vendor != PCI_VENDOR_ID_ADVANTECH)
continue;
- /*
- * Look for device that isn't in use.
- * Enable PCI device and request regions.
- */
- if (comedi_pci_enable(pcidev, "adv_pci1723"))
+ if (pci_is_enabled(pcidev))
continue;
return pcidev;
}
@@ -335,6 +331,10 @@ static int pci1723_attach(struct comedi_device *dev,
if (!devpriv->pcidev)
return -EIO;
+ ret = comedi_pci_enable(devpriv->pcidev, "adv_pci1723");
+ if (ret)
+ return ret;
+
dev->iobase = pci_resource_start(devpriv->pcidev, 2);
dev->board_name = this_board->name;
--
1.7.11
next reply other threads:[~2012-07-19 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 1:30 H Hartley Sweeten [this message]
2012-07-19 9:37 ` [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach Ian Abbott
2012-07-19 17:12 ` H Hartley Sweeten
2012-07-19 23:17 ` gregkh
2012-07-19 23:31 ` H Hartley Sweeten
2012-07-19 23:35 ` gregkh
2012-07-19 23:58 ` H Hartley Sweeten
2012-07-20 0:15 ` gregkh
2012-07-20 16:33 ` H Hartley Sweeten
2012-07-20 18:01 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207181830.48668.hartleys@visionengravers.com \
--to=hartleys@visionengravers.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox