From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858Ab2GRX1a (ORCPT ); Wed, 18 Jul 2012 19:27:30 -0400 Received: from fieldses.org ([174.143.236.118]:55715 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241Ab2GRX12 (ORCPT ); Wed, 18 Jul 2012 19:27:28 -0400 Date: Wed, 18 Jul 2012 19:27:27 -0400 From: "J. Bruce Fields" To: Stanislav Kinsbursky Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, devel@openvz.org Subject: Re: [PATCH v2] NFSd: simplify locking in nfsd_recall_delegations() Message-ID: <20120718232727.GA5347@fieldses.org> References: <20120703130215.4035.8190.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120703130215.4035.8190.stgit@localhost.localdomain> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2012 at 05:02:24PM +0400, Stanislav Kinsbursky wrote: > v2: rebased on 3.5-rc3 kernel > > Holding of client_mutex looks redundant here - recall_lock looks enough. Yep, thanks.--b. > > Signed-off-by: Stanislav Kinsbursky > --- > fs/nfsd/nfs4state.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 33eccee..480ecc9 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -4622,7 +4622,6 @@ void nfsd_recall_delegations(u64 num) > LIST_HEAD(victims); > struct nfs4_delegation *dp, *dnext; > > - nfs4_lock_state(); > spin_lock(&recall_lock); > count = nfsd_process_n_delegations(num, &victims); > list_for_each_entry_safe(dp, dnext, &victims, dl_recall_lru) { > @@ -4630,7 +4629,6 @@ void nfsd_recall_delegations(u64 num) > nfsd_break_one_deleg(dp); > } > spin_unlock(&recall_lock); > - nfs4_unlock_state(); > > printk(KERN_INFO "NFSD: Recalled %d delegations", count); > } >