From: Feng Tang <feng.tang@intel.com>
To: Len Brown <len.brown@intel.com>, <linux-kernel@vger.kernel.org>
Cc: <x86@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Donald Dutile <ddutile@redhat.com>,
Alexander Gordeev <agordeev@redhat.com>,
Bob Moore <robert.moore@intel.com>,
Lin Ming <ming.m.lin@intel.com>
Subject: Re: [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion
Date: Thu, 19 Jul 2012 15:47:27 +0800 [thread overview]
Message-ID: <20120719154727.3306bfe4@feng-i7> (raw)
In-Reply-To: <1342683564-2245-2-git-send-email-feng.tang@intel.com>
Update the commit log.
Thanks,
Feng
>From 61e3349625843bd9e4c353598ec50a2333409986 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Wed, 18 Jul 2012 15:01:18 +0800
Subject: [PATCH 2/2] ACPI: Remove acpi_get_table_with_size() fucntion
Remove the unnecessary acpi_get_table_with_size(), as it could
be well covered by acpi_get_table().
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
drivers/acpi/acpica/tbxface.c | 18 +++---------------
include/acpi/acpixf.h | 4 ----
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
index abcc641..3daf93d 100644
--- a/drivers/acpi/acpica/tbxface.c
+++ b/drivers/acpi/acpica/tbxface.c
@@ -380,7 +380,7 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
/*******************************************************************************
*
- * FUNCTION: acpi_get_table_with_size
+ * FUNCTION: acpi_get_table
*
* PARAMETERS: Signature - ACPI signature of needed table
* Instance - Which instance (for SSDTs)
@@ -392,9 +392,8 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
*
******************************************************************************/
acpi_status
-acpi_get_table_with_size(char *signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size)
+acpi_get_table(char *signature,
+ u32 instance, struct acpi_table_header **out_table)
{
u32 i;
u32 j;
@@ -424,7 +423,6 @@ acpi_get_table_with_size(char *signature,
acpi_tb_verify_table(&acpi_gbl_root_table_list.tables[i]);
if (ACPI_SUCCESS(status)) {
*out_table = acpi_gbl_root_table_list.tables[i].pointer;
- *tbl_size = acpi_gbl_root_table_list.tables[i].length;
}
if (!acpi_gbl_permanent_mmap) {
@@ -436,16 +434,6 @@ acpi_get_table_with_size(char *signature,
return (AE_NOT_FOUND);
}
-
-acpi_status
-acpi_get_table(char *signature,
- u32 instance, struct acpi_table_header **out_table)
-{
- acpi_size tbl_size;
-
- return acpi_get_table_with_size(signature,
- instance, out_table, &tbl_size);
-}
ACPI_EXPORT_SYMBOL(acpi_get_table)
/*******************************************************************************
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 18f023a..63a4b26 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -172,10 +172,6 @@ acpi_get_table_header(acpi_string signature,
struct acpi_table_header *out_table_header);
acpi_status
-acpi_get_table_with_size(acpi_string signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size);
-acpi_status
acpi_get_table(acpi_string signature,
u32 instance, struct acpi_table_header **out_table);
--
1.7.1
next prev parent reply other threads:[~2012-07-19 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 7:39 [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
2012-07-19 7:47 ` Feng Tang [this message]
2012-07-31 3:21 ` Len Brown
2012-07-19 7:45 ` [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-31 3:20 ` Len Brown
2012-07-31 20:56 ` Yinghai Lu
2012-08-01 2:06 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719154727.3306bfe4@feng-i7 \
--to=feng.tang@intel.com \
--cc=agordeev@redhat.com \
--cc=ddutile@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox