From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, abbotti@mev.co.uk
Subject: Re: [PATCH 00/90] staging: comedi: cleanup the pci_dev usage
Date: Thu, 19 Jul 2012 16:53:21 -0700 [thread overview]
Message-ID: <20120719235321.GA13482@kroah.com> (raw)
In-Reply-To: <201207181823.21230.hartleys@visionengravers.com>
On Wed, Jul 18, 2012 at 06:23:20PM -0700, H Hartley Sweeten wrote:
> All the comedi pci drivers currently store a pointer to the pci_dev
> in their private data. We can use the 'struct device *hw_dev' variable
> in the comedi_device struct instead and introduce a wrapper for
> to_pci_dev() to allow the drivers to easily get the pci_dev.
>
> This patchset does just that. It also removes the private data from
> the drivers that no longer needed it.
>
> Some of the drivers required a bit of cleanup to their "find pci device"
> code or the private data in order to make the conversion cleaner.
>
> There are still a couple drivers, specifically the ni and addi ones,
> that need additional work before they can be converted cleanly.
I've applied all of these (with the updated 01/90 patch). Can you
please send follow-on patches to resolve the issues that Ian pointed
out?
thanks,
greg k-h
next prev parent reply other threads:[~2012-07-19 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 1:23 [PATCH 00/90] staging: comedi: cleanup the pci_dev usage H Hartley Sweeten
2012-07-19 23:53 ` Greg KH [this message]
2012-07-20 0:03 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719235321.GA13482@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox