From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Paul Mundt <lethal@linux-sh.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: Boot breaks in -next from LEGACY to LINEAR conversion
Date: Fri, 20 Jul 2012 10:42:49 +0100 [thread overview]
Message-ID: <20120720094248.GM4495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACxGe6utvV6XbJEck_UuVJxsqckPFZXG3psEgeQ1vZSBGAwm9Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Jul 19, 2012 at 10:30:11PM -0600, Grant Likely wrote:
> Okay, I've got a theory about what the issue is now. The .map()
> callback is failing (returning non-zero) for one of the hwirqs. The
> new code is stricter about associations, and actually unwinds the
> associations if one of them fails. The old legacy code simply called
> all the .map() hooks blindly without any error checking. Can you send
> me the kernel log after backing out those changes.
Looks like the error checking is the issue. Always knew that was a bad
idea :) I've just sent a patch to improve the diagnostics here which
might help a bit, though I realise now with some of my debug I need to
send a v2 :/ .
On my system there's only one mapping failed, but it's for one of the
VIC mappings which is rather unfortunate. The error is there because
the VIC is returning -ENOTSUPP to skip invalid IRQs which doesn't
immediately seem like an awful thing to do for generic code like this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-07-20 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 18:57 Boot breaks in -next from LEGACY to LINEAR conversion Mark Brown
2012-07-18 0:52 ` Paul Mundt
2012-07-18 10:16 ` Mark Brown
2012-07-18 16:10 ` Mark Brown
2012-07-18 16:27 ` Grant Likely
2012-07-20 4:30 ` Grant Likely
2012-07-20 9:42 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720094248.GM4495@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).