From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tty: save newly allocated buffer in tty_free_termios()
Date: Fri, 20 Jul 2012 15:00:45 +0100 [thread overview]
Message-ID: <20120720150045.43828c39@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120720133245.GD22245@elgon.mountain>
On Fri, 20 Jul 2012 16:32:45 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We're trying to save the termios state and we need to allocate a buffer
> to do it. Smatch complains that the buffer is leaked at the end of the
> function.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Cox <alan@linux.intel.com>
(introduced in the recent patches so no need to go back into stable or
anywhere like that)
prev parent reply other threads:[~2012-07-20 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 13:32 [patch] tty: save newly allocated buffer in tty_free_termios() Dan Carpenter
2012-07-20 14:00 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720150045.43828c39@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox