From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784Ab2GWAUx (ORCPT ); Sun, 22 Jul 2012 20:20:53 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:40585 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677Ab2GWAUu (ORCPT ); Sun, 22 Jul 2012 20:20:50 -0400 Date: Sun, 22 Jul 2012 20:20:43 -0400 From: "Theodore Ts'o" To: Dan Carpenter , Zheng Liu , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch -next] ext4: locking issue on error path Message-ID: <20120723002043.GF9958@thunk.org> Mail-Followup-To: Theodore Ts'o , Dan Carpenter , Zheng Liu , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20120717063106.GA14985@elgon.mountain> <20120717081351.GA4513@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120717081351.GA4513@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2012 at 04:13:51PM +0800, Zheng Liu wrote: > On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote: > > We recently changed how the locking worked here, but this error path was > > missed. > > > > Signed-off-by: Dan Carpenter > > Sorry, it is my fault. Thanks for pointing out this bug. Since this patch hadn't been promoted past the master branch pointer (it was only in the dev branch, which can be rebased), I've merged this fix up with Zheng's original patch. Dan, may thanks for finding and pointing it out!! - Ted