Re: [PATCH] gpiolib: Use seq_file's iterator interface

Arnd Bergmann
2012-05-12T12:56:22Z

On Thursday 12 April 2012, Thierry Reding wrote:
> When dumping a collection of items via seq_file, it is recommended to
> use the iterator interface. For the gpiolib debugfs interface this can
> be done to dump each GPIO chip in turn.
>
> Note that for gpiolib this is a little cumbersome because it does not
> provide a list of registered GPIO chips and the only way to iterate is
> over each GPIO individually. Once a chip is found, the number of GPIOs
> it provides can be skipped as a small optimization.
>
> This patch was requested by Arnd Bergmann here:
>
> http://article.gmane.org/gmane.linux.ports.tegra/3535
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-kernel@vger.kernel.org

Reviewed-by: Arnd Bergmann <arnd@arndb.de>