Re: [PATCH] gpiolib: Use seq_file's iterator interface

Thierry Reding
2012-07-23T12:12:43Z

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On Sat, May 12, 2012 at 12:56:14PM +0000, Arnd Bergmann wrote:
> On Thursday 12 April 2012, Thierry Reding wrote:
> > When dumping a collection of items via seq_file, it is recommended to
> > use the iterator interface. For the gpiolib debugfs interface this can
> > be done to dump each GPIO chip in turn.
> >
> > Note that for gpiolib this is a little cumbersome because it does not
> > provide a list of registered GPIO chips and the only way to iterate is
> > over each GPIO individually. Once a chip is found, the number of GPIOs
> > it provides can be skipped as a small optimization.
> >
> > This patch was requested by Arnd Bergmann here:
> >
> > http://article.gmane.org/gmane.linux.ports.tegra/3535
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > Cc: Linus Walleij <linus.walleij@stericsson.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: linux-kernel@vger.kernel.org
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Grant, Linus,

Is this good to go?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]