From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: platform-driver-x86@vger.kernel.org,
Arun Raghavan <arun.raghavan@collabora.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apple-gmux: Fix kconfig dependencies
Date: Mon, 23 Jul 2012 08:44:27 -0500 [thread overview]
Message-ID: <20120723134427.GA3524@thinkpad-t410> (raw)
In-Reply-To: <20120723133010.GE21495@srcf.ucam.org>
On Mon, Jul 23, 2012 at 02:30:10PM +0100, Matthew Garrett wrote:
> > I'm looking at Andreas's code for switcharoo support, and something I
> > want to do along with it is make apple-gmux not dependent on backlight
> > support (i.e. you can still build switcharoo support if
> > BACKLIGHT_CLASS_DEVICE is disabled). I'm assuming this patch as a
> > prerequisite. But things do get really monstrously ugly, so if there's a
> > cleaner way to enforce this that I haven't found I'd love to hear about
> > it.
>
> Why do you want to support that case? One of the problems we have with
> the kernel at present is that it's trivial to come up with non-sensical
> configurations. I can't think of a single case where you'd want the gmux
> support without also having the backlight support code.
Just because there isn't strictly any reason that the switching code
needs to depend on backlight support. But yes, I can't think of a good
reason why anyone would want this configuration. I won't mess with it
then.
Seth
next prev parent reply other threads:[~2012-07-23 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 14:55 [PATCH] apple-gmux: Fix kconfig dependencies Seth Forshee
2012-07-16 23:50 ` Seth Forshee
2012-07-23 13:30 ` Matthew Garrett
2012-07-23 13:44 ` Seth Forshee [this message]
2012-07-23 15:28 ` Randy Dunlap
2012-07-23 16:08 ` Seth Forshee
2012-08-02 17:15 ` Seth Forshee
2012-08-02 20:19 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723134427.GA3524@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=arun.raghavan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox